If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Status Bar; Document: Done (0.78secs) should be changed to Document: Done (0.78 secs)

VERIFIED FIXED

Status

SeaMonkey
MailNews: Message Display
VERIFIED FIXED
17 years ago
13 years ago

People

(Reporter: stephend@netscape.com (gone - use stephen.donner@gmail.com instead), Assigned: Peter ``jag'' Annema)

Tracking

({l12y})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Status Bar; Document: Done (0.078secs) should be changed to Document: Done
(0.078secs)


Self explanatory.

Hwaara has a patch.  He'll attach.
Er...should be changed to Document: Done (0.078 secs).
Keywords: patch, ui
QA Contact: esther → nbaca
Summary: Status Bar; Document: Done (0.078secs) should be changed to Document: Done (0.078secs) → Status Bar; Document: Done (0.078secs) should be changed to Document: Done (0.078 secs)

Comment 2

17 years ago
Status bar is currently showing "Document: Done (0.XXsecs)". It should be a
space between the number and "secs".

I will attach a fix for this in a couple of minutes.

Updated

17 years ago
Summary: Status Bar; Document: Done (0.078secs) should be changed to Document: Done (0.078 secs) → Status Bar; Document: Done (0.78secs) should be changed to Document: Done (0.78 secs)

Comment 3

17 years ago
Created attachment 23082 [details] [diff] [review]
[Patch] fix

Comment 4

17 years ago
And what about: 'Document: done (0.78 secs).'

Comment 5

17 years ago
i'm concerned that our current patch is biased towards English.

seeking advise on how to do this correctly for English without imparing other 
languages.

I suspect the correct approach is a string of the form "blah blahe%subst%elbah" 
where %subst% is substituted by javascript.
Keywords: l12y
timeless is absolutely correct. 

an example from my new bookmarks window:

displayValue = gBookmarksShell.getLocaleString("status_foldercount");
displayValue = displayValue.replace(/%num_items%/, count);

Comment 8

17 years ago
So would I apply this, to make it a space for en-XX languages?

Comment 9

17 years ago
according to other bugs %blah% syntax is wrong, and we should be using $1%s or 
something, ref other bug. i'll gladly r= a bug that satisfies those 
constraints...

Comment 10

17 years ago
See also bug 48436 and bug 65710.

I've also seen XUL files where something like `%1%' (not sure of the exact 
syntax) is used to allow for localization, e.g. `Downloaded %1% of %2%'. Can't 
find any with LXR, though, since LXR doesn't index the `%' character.
How about we just get rid of the timer's display altogether? 

Comment 12

17 years ago
jag is nice enough to care of this bug!
Assignee: hwaara → disttsc
(Assignee)

Comment 13

17 years ago
mao: wanna take a shot at turning this into "Document: Done (%S secs)"?

Comment 14

17 years ago
Created attachment 26695 [details] [diff] [review]
patch - localizeable version
(Assignee)

Comment 15

17 years ago
r=jag
sr=sspitzer

Comment 17

17 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 18

17 years ago
Yup. It works now using trunkbuild, built it now.

VERIFIED.
Status: RESOLVED → VERIFIED
Also verified on linux, build 2001030508 Mandrake 7.2 with KDE, and Windows 2000
build 2001030505.
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.