Closed
Bug 660887
Opened 13 years ago
Closed 13 years ago
Double tap on an empty space on the tab bar should open a new tab
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 10
People
(Reporter: padenot, Assigned: mbrubeck)
References
Details
(Keywords: platform-parity, ux-consistency, ux-efficiency)
Attachments
(1 file, 2 obsolete files)
5.15 KB,
patch
|
mfinkle
:
review+
mbrubeck
:
ui-review+
|
Details | Diff | Splinter Review |
When using Fennec for the first time, I tried to double tap on an empty space on the tab bar, to open a new tab, and this didn't work. I guess this behavior should be implemented, as it is consistent with the desktop browser (double click on an empty space opens a new tab).
Comment 1•13 years ago
|
||
Assignee: nobody → 21
Attachment #536339 -
Flags: review?(mark.finkle)
Comment 2•13 years ago
|
||
This is a duplicate of bug 563973.
Comment 3•13 years ago
|
||
on IRC, Madhava said he did not want to add this feature to the core browser. It's too hidden and could be executed during an accidental double-tap more often than in desktop Firefox. An add-on could add this behavior if it wanted to.
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → WONTFIX
Updated•13 years ago
|
Attachment #536339 -
Flags: review?(mark.finkle)
Comment 4•13 years ago
|
||
I don't think we want to do this. Doubletap isn't really a widely used interaction on touch devices other than for zoom - I'm not sure that it's worth using this as a one-off interaction for something where there is a easy and near-at-hand alternative (the button).
Comment 7•13 years ago
|
||
For me, holding a tablet, the button isn't near at hand. It's a long reach for my reasonably lengthy thumb. Also, I don't care about this on phones and my bug which was duped here was filed against tablets and not phones if that makes a difference in reconsidering the wontfix.
Assignee | ||
Comment 8•13 years ago
|
||
I agree this is worth re-opening because of tablets. This patch is basically like Vivien's, but it uses "TapDouble" instead of "dblclick" because dblclick is hard to trigger on a touchscreen. (You have to tap twice in pretty much exactly the same place for dblclick, while TapDouble is more lenient.)
Assignee: 21 → mbrubeck
Attachment #536339 -
Attachment is obsolete: true
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Assignee | ||
Updated•13 years ago
|
Status: REOPENED → ASSIGNED
OS: Linux → All
Hardware: x86 → All
Whiteboard: [has patch]
Comment 10•13 years ago
|
||
You're right for dblclick in general but in this case it's not really relevant since the tab bar is huge :) But dblclick will probably not fired for some platforms so TapDouble is likely the right approach. The only thing I don't like is using BrowserUI.addTab() directly into tabs.xml, could you use the same mechanism use for reloadtab & co?
Assignee | ||
Comment 11•13 years ago
|
||
This addresses Vivien's comments above. This also adds a clickcount="1" filter to the main onclick handler, to prevent it from firing at the same time as a TapDouble. (Without that change, if your double-tap hits an existing tab, then it opens a new tab but selects the old tab.)
Attachment #565064 -
Attachment is obsolete: true
Attachment #565119 -
Flags: review?(mark.finkle)
Comment 12•13 years ago
|
||
Comment on attachment 565119 [details] [diff] [review] patch v2 > <binding id="tablist"> > </content> >+ <handlers> >+ <handler event="TapDouble" action="this._onDoubleTap();"/> >+ </handlers> > <implementation> Add blank lines before and after r+, but you still need Madhava's approval on this
Attachment #565119 -
Flags: ui-review?(madhava)
Attachment #565119 -
Flags: review?(mark.finkle)
Attachment #565119 -
Flags: review+
Comment 13•13 years ago
|
||
So this won't work on the mobile phone, only on tablet?
Assignee | ||
Comment 14•13 years ago
|
||
This patch will actually work on in both the phone and and tablet layouts.
Comment 15•13 years ago
|
||
OK. let's land it and see what we think.
Assignee | ||
Comment 16•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/979075e871e2
Assignee | ||
Updated•13 years ago
|
Attachment #565119 -
Flags: ui-review?(madhava) → ui-review+
Assignee | ||
Comment 17•13 years ago
|
||
Backed out because the Fennecmark Tzoom benchmark breaks with this change: https://hg.mozilla.org/integration/mozilla-inbound/rev/ab95694a2977 Filed bug 692811 for fixing Fennecmark. When that is fixed, we can re-land this patch.
Whiteboard: [pushed] → [blocked on dependencies]
Assignee | ||
Comment 18•13 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/81d3eb93437d
Whiteboard: [blocked on dependencies]
Comment 19•13 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/81d3eb93437d
Status: ASSIGNED → RESOLVED
Closed: 13 years ago → 13 years ago
Resolution: --- → FIXED
Comment 20•13 years ago
|
||
Build ID: Mozilla/5.0 (Android; Linux armv7l; rv:10.0a1) Gecko/20111031 Firefox/10.0a1 Fennec/10.0a1 Device: HTC Desire Z - Android 2.3 Asus Transformer TF101 - Android 3.1 Verified on phone and tablet: when double tapping on an empty space on the tab bar a new tab is opened. Also when double tapping on an existing tab, a new tab is opened and the tapped tab is selected. Is this a expected, or is it a new issue?
You need to log in
before you can comment on or make changes to this bug.
Description
•