660902 - Recommended status is incorrect for search tools/themes

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: API, defect, P3)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Load https://addons.allizom.org/en-US/firefox/api/1.5/search/searchpreview
2. Notice the value of <featured>

expected behavior:
<featured>1</featured> since Search Preview is  featured (https://addons.mozilla.org/en-US/firefox/addon/searchpreview/)

observed behavior:
For search tools, the recommended status is 0

Comment 1

[krupa raj[:krupa]]

Same for Themes: https://addons.allizom.org/en-US/firefox/api/1.5/search/walnut

Comment 2

[Wil Clouser [:clouserw]]

-> andym did this

Comment 3

[Andy McKay]

It looks like there's a few different concepts of being featured. Search tools and Themes have custom code to decide if the show up in the browse view.

Comment 4

[Andy McKay]

Comment 0: Search tools uses category featured (and shows featured on the buttons). So I've added that in for searchpreview.

https://github.com/jbalogh/zamboni/commit/bb70380abbe97935ef39a446e3d668407ae77fc6

Comment 1: Walnut is a theme and shows up on the browse pages but that doesn't mean its featured. The theme page just show the listed addons.

Comment 5

[krupa raj[:krupa]]

Themes and search tools have featured = 1

verified at
https://addons.allizom.org/en-US/firefox/api/1.5/search/walnut
https://addons.allizom.org/en-US/firefox/api/1.5/search/searchpreview