660920 - IE8 an error message to upgrade a modern browser is not displayed

Status: VERIFIED FIXED

(Websites Graveyard :: markup.mozilla.org, defect)

Description

[Matt Brandt [:mbrandt]]

Attachment: Screen shot of IE8

Please correct me if I'm mistaken. I thought IE8 was on the list of non-supported browsers.

Steps to reproduce:
1. Using IE8 go to markup-dev

Expected:
An error message suggesting the user upgrade to a modern browser is displayed.

Actual:
A popup window is displayed by IE8 with the following error message. The page also renders as mostly empty.
------
Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0)
Timestamp: Tue, 31 May 2011 18:28:33 UTC


Message: 'CanvasRenderingContext2D' is undefined
Line: 27
Char: 1
Code: 0
URI: https://markup-dev.allizom.org/media/assets/js/markUp_app.min.js

Comment 1

[[:brez]]

All set:

https://github.com/mozilla/markup/commit/3b579e823cf99228d8c37bceaf6d23b13aec9f0b

Comment 2

[Matt Brandt [:mbrandt]]

hmm, has this patch landed on the dev env? I'm still experiencing the same behavior as seen in comment 0?

Comment 3

[Matt Brandt [:mbrandt]]

reopening for further investigation. I'm still seeing the broken behavior in IE8.

Here's a brief screencast -> http://screencast.com/t/JKJTjBoKQE

Let me know what additional artifacts I can provide to help diagnose the problem.

Comment 4

[[:brez]]

Making sure the feature detection script actually runs, and fixing a bug in canvas

https://github.com/mozilla/markup/commit/419493f9effc7dbaa1a879cb27ffbb01c15db0b2

Comment 5

[Matt Brandt [:mbrandt]]

Thanks for the patch... the error message is displaying again in IE 8. QA verified.

Comment 6

[Matt Brandt [:mbrandt]]

Attachment: Upgrade error message in IE8

And a screenshot of the upgrade message.