Unused result of SendPMemoryReportRequestConstructor

RESOLVED WORKSFORME

Status

()

RESOLVED WORKSFORME
7 years ago
6 years ago

People

(Reporter: jdm, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning] [good first bug] [mentor=jdm] [lang=c++])

(Reporter)

Description

7 years ago
/home/t_mattjo/src/firefox/mobilebase/dom/ipc/ContentParent.cpp: In member function ‘virtual nsresult mozilla::dom::ContentParent::Observe(nsISupports*, const char*, const PRUnichar*)’:
/home/t_mattjo/src/firefox/mobilebase/dom/ipc/ContentParent.cpp:624: warning: ignoring return value of ‘mozilla::dom::PContentParent::PMemoryReportRequestParent* mozilla::dom::PContentParent::SendPMemoryReportRequestConstructor()’, declared with attribute warn_unused_result

We should probably just pop a |mozilla::unused <<| in front of the call.
This might be an interesting error, not sure.
Component: IPC → XPCOM
QA Contact: ipc → xpcom
(Reporter)

Comment 2

7 years ago
Chris: what if we called SetChildMemoryReporters(emptyTArray) in the case of failure here? Does that seem sensible?
(Reporter)

Updated

7 years ago
Whiteboard: [build_warning] [good first bug] [mentor=jdm] → [build_warning] [good first bug] [mentor=jdm] [lang=c++]
(Reporter)

Comment 4

6 years ago
Warning is gone.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.