661025 - Featured flag missing for add-on buttons

Status: VERIFIED FIXED

Description

[krupa raj[:krupa]]

Created attachment 536450 [details]
screenshot

steps to reproduce:
1. Load https://addons.allizom.org/z/en-us/firefox/i/addon/foxyproxy-standard/
2. Notice the install button

observed behavior:
Featured flag is missing from the install buttons.

Comment 1

[Wil Clouser [:clouserw]]

Chowse, do we have mockups for what featured add-on badges are supposed to look like?

Comment 2

[Potch [:potch]]

I took a crack at them:

https://github.com/jbalogh/zamboni/commit/44af4c1

Comment 3

[Wil Clouser [:clouserw]]

(In reply to comment #2)
> I took a crack at them:
> 
> https://github.com/jbalogh/zamboni/commit/44af4c1

Localizers will have a ball with that :)  (also, text-instead-of-image ftw)


Chowse - what's going on with this bug?

Comment 4

[Chris Howse [:chowse]]

(In reply to comment #3)
> (In reply to comment #2)
> > I took a crack at them:
> > 
> > https://github.com/jbalogh/zamboni/commit/44af4c1
> 
> Localizers will have a ball with that :)  (also, text-instead-of-image ftw)

Potch's update is the intended design for featured add-ons (top-right banner, same colors as the Featured decal on listing pages).

I'd only suggest two (optional) tweaks:

* Move the banner 2px up and to the right, so it appears to "wrap around" the
  main block.

* Bump the vertical padding around the block up to 7px (or .5em). I think it's
  a little scrawny at the moment.

Comment 5

[Wil Clouser [:clouserw]]

Thanks, back to potch for the tweak and we can close

Comment 6

[Potch [:potch]]

This is all spruced up now!
https://github.com/jbalogh/zamboni/commit/29bf21ab07

Comment 7

[krupa raj[:krupa]]

verified fixed @ https://addons-next.allizom.org/z/en-US/firefox/i/addon/stumbleupon/