The default bug view has changed. See this FAQ.

Devirtualize some RasterImage methods

RESOLVED FIXED in mozilla7

Status

()

Core
ImageLib
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: khuey, Assigned: khuey)

Tracking

Trunk
mozilla7
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Created attachment 536471 [details] [diff] [review]
Patch

We know the concrete type at compile time, so these being virtual just adds overhead.
Attachment #536471 - Flags: review?(joe)
Just for history -- these have been virtual ever since they were moved from imgIContainer.idl into RasterImage, in this cset:
 http://hg.mozilla.org/mozilla-central/rev/205795b2962a

I don't think I intentionally made them virtual - I may have just done it mechanically, with the idea of mostly preserving the methods' signatures as they were shifted off of the interface.

So anyway, I fully support this change. :)
Version: unspecified → Trunk
Comment on attachment 536471 [details] [diff] [review]
Patch

Review of attachment 536471 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #536471 - Flags: review?(joe) → review+
http://hg.mozilla.org/mozilla-central/rev/51b64ac421e3
Flags: in-testsuite-
Target Milestone: --- → mozilla7
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Updated

6 years ago
Depends on: 687295
No longer depends on: 687295
You need to log in before you can comment on or make changes to this bug.