Closed
Bug 661088
Opened 14 years ago
Closed 14 years ago
`cfx docs` doesn't tell me it's "opening web browser" on Windows
Categories
(Add-on SDK Graveyard :: General, defect, P2)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: myk, Unassigned)
Details
Attachments
(1 file)
891 bytes,
patch
|
myk
:
review-
|
Details | Diff | Splinter Review |
`cfx docs` is supposed to tell me it's "Opening web browser to http://127.0.0.1:8888/." when I first issue the command, but it doesn't do so on Windows. Instead, it only tells me "One moment.":
(addon-sdk)
myk@MYKPAD ~/Projects/addon-sdk
$ cfx docs
One moment.
(addon-sdk)
myk@MYKPAD ~/Projects/addon-sdk
$
It does eventually tell me that, however. And if I turn off stdout/stderr buffering, the message appears when I first issue the command:
(addon-sdk)
myk@MYKPAD ~/Projects/addon-sdk
$ export PYTHONUNBUFFERED=1
(addon-sdk)
myk@MYKPAD ~/Projects/addon-sdk
$ cfx docs
One moment.
Opening web browser to http://127.0.0.1:8888/.
(addon-sdk)
myk@MYKPAD ~/Projects/addon-sdk
$
I don't think I've seen this on other platforms. Windows-specific buffering issue?
Reporter | ||
Updated•14 years ago
|
Priority: -- → P3
Target Milestone: --- → 1.0
Comment 1•14 years ago
|
||
Sounds likely.. windows seems to have different defaults for buffering, or a different buffer size. Does the attached patch help?
Attachment #536771 -
Flags: review?(myk)
Reporter | ||
Comment 2•14 years ago
|
||
Comment on attachment 536771 [details] [diff] [review]
flush stdout during 'cfx docs'
Strangely, it doesn't, although it certainly looks like it would.
Attachment #536771 -
Flags: review?(myk) → review-
Reporter | ||
Comment 3•14 years ago
|
||
(automatic reprioritization of 1.0 bugs)
Priority: P3 → P2
Target Milestone: 1.0 → 1.1
(Pushing all open bugs to the --- milestone for the new triage system)
Target Milestone: 1.1 → ---
Myk, you recently landed some stuff about logging to the console, right? Did it fix this, by chance?
Reporter | ||
Comment 6•14 years ago
|
||
The message ended up going away with server.py in https://github.com/mozilla/addon-sdk/commit/3b08b3b4ffccfcc16d04e381ccc11607f0f46c4c, so I don't know if that (would have) fixed this. :-)
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → INVALID
You need to log in
before you can comment on or make changes to this bug.
Description
•