Closed Bug 661113 Opened 13 years ago Closed 13 years ago

Progress with "-moz-orient: vertical;" should have vertical dimensions by default

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla6
Tracking Flags:
Tracking Status
firefox5 --- unaffected
firefox6 - fixed
firefox7 --- fixed

People

(Reporter: mounir, Assigned: mounir)

References

Details

(Keywords: dev-doc-complete)

Attachments

(1 file)

Patch v1
19.06 KB, patch
roc
: review+
jst
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
The fix is simple and I think we should have this in Firefox 6.
Attached patch Patch v1 — — Splinter Review 

        Attachment #536559 -
        Flags: review?(roc)

    
  
Status: NEW → ASSIGNED
Whiteboard: [needs review]

    
  

          tracking-firefox6:
          --- → ?

    
  
Summary: Make progress with "-moz-orient: vertical;" vertical by default → Progress with "-moz-orient: vertical;" should have vertical dimensions by default

    
    

    
  
Once this is in, I need to remove the note pointing out this issue from the docs.
Keywords: dev-doc-needed

    
    

    
  
Comment on attachment 536559 [details] [diff] [review]
Patch v1

Review of attachment 536559 [details] [diff] [review]:
-----------------------------------------------------------------

        Attachment #536559 -
        Flags: review?(roc) → review+

    
  
Flags: in-testsuite+
Whiteboard: [needs review] → [fixed in cedar]

    
    

    
  
Not tracking for 6, but I'll approve the patch.

          tracking-firefox6:
          ? → -

        Attachment #536559 -
        Flags: approval-mozilla-aurora+

    
    

    
  
Pushed in m-c:
http://hg.mozilla.org/mozilla-central/rev/0dcb87dd99bd
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Whiteboard: [fixed in cedar]
Target Milestone: --- → mozilla7

    
    

    
  
So this will not push to Firefox 6? Ugh.
Keywords: dev-doc-needed → dev-doc-complete

    
    

    
  
(In reply to comment #6)
> So this will not push to Firefox 6? Ugh.

I just push that patch to mozilla-aurora repo so it is going to be fixed in Firefox 6.
http://hg.mozilla.org/releases/mozilla-aurora/rev/b8b338852538

          status-firefox5:
          --- → unaffected

          status-firefox6:
          --- → fixed

          status-firefox7:
          --- → fixed

    
  
Target Milestone: mozilla7 → mozilla6

    
    

    
  
Setting resolution to Verified Fixed.
If you feel otherwise,please feel free to change the status.
Thanks!
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.