661247 - remove utf-8 encoding from sreg reset password email To: and From: headers

Status: VERIFIED FIXED

(Cloud Services :: Server: Core, defect)

Description

[Tarek Ziadé (:tarek)]

The encoding of the headers should not occur when there are no non-ascii characters.

(services.util.send_email)

Comment 1

[:Atoll]

To: and From: headers, specifically.  it's perfectly okay to encode Subject:.

Comment 2

[Tarek Ziadé (:tarek)]

More precisely, only the Real Name part, of present needs to be encoded.

http://www.ietf.org/rfc/rfc2047.txt

Comment 3

[Tarek Ziadé (:tarek)]

Attachment: This patch makes sure only the Real Name igets encoded in the To anf From field, if provided

Comment 4

[Toby Elliott [:telliott]]

Comment on attachment 536730 [details] [diff] [review]
This patch makes sure only the Real Name igets encoded in the To anf From field, if provided

Looks good. I'm a little concerned about the regex picking up stray other stuff, and you might want to toss an @ into the second part to ensure an email address. but it should work.

Comment 5

[Tarek Ziadé (:tarek)]

This regexp is just looking for the "real name <email>" pattern without any strict control on whether the email is valid or not.  We have another function that does this in util (valid_email)

We could add a call to it in send_email for controlling the emails but I guess that'd be a new feature

Comment 6

[Tarek Ziadé (:tarek)]

Attachment: Better patch: uses rfc822.AddressList to parse the address

Comment 7

[Toby Elliott [:telliott]]

Comment on attachment 536740 [details] [diff] [review]
Better patch: uses rfc822.AddressList to parse the address

Well, that seems a lot simpler.

Comment 8

[Tarek Ziadé (:tarek)]

done in https://hg.mozilla.org/services/server-core/rev/8eb9a62f0862

Comment 9

[Tracy Walker [:tracy]]

verified on stage 20110616