661350 - "ghetto_time_ago_in_words" returns empty string for times under 3 minutes

Status: RESOLVED FIXED

(Socorro :: General, task)

Description

[Robert Helmer [:rhelmer]]

We should inspect all uses of this function and rename or replace it with something that has more reasonable behavior.

I assume that somewhere in the codebase returning an empty string is desired, I think that should be local or at least configurable behavior, not the default for a general-purpose time formatting function.

See bug 661153 for a concrete example of the bug here.

Comment 1

[Brandon Savage [:brandon]]

Attachment: Rename function, add/update tests

I opted not to rewrite this function. It may not represent the best PHP but it could be fixed within the scope of the bug and without a rewrite.

The function now returns the number of seconds if less than 1 minute, and figures out the time after that. This patch also improves the way the front end handles the returned data to be more consistent.

Comment 2

[Brandon Savage [:brandon]]

Attachment: Making sure tests will pass

The previous test had a bug, this fixes that bug.

Comment 3

[Laura Thomson :laura]

Comment on attachment 547112 [details] [diff] [review]
Making sure tests will pass

Please change "Givens" to "Gives" as it makes my head hurt :)

This is better, and will do for now.

Comment 4

[Brandon Savage [:brandon]]

This issue was fixed prior to branching 2.1.

Comment 5

[Stephen Donner [:stephend] Not actively reading bugmail]

Is this QA-testable?  If not, can we add [qa-], since it also has a unit test?  Thanks!