Closed
Bug 661395
Opened 14 years ago
Closed 4 years ago
Google code for their +1 button works in other major browsers but not Firefox
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
INCOMPLETE
People
(Reporter: RobS.mozilla9, Unassigned)
References
()
Details
Attachments
(1 file)
|
329 bytes,
text/html
|
Details |
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0.1) Gecko/20100101 Firefox/4.0.1
Build Identifier: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:2.0.1) Gecko/20100101 Firefox/4.0.1 --or-- Mozilla/5.0 (Windows NT 6.1; rv:2.0.1) Gecko/20100101 Firefox/4.0.1
Google released their code for their "+1 Button" (http://www.Google.com/webmasters/%2b1/button/) and it works in Safari, Chrome, Opera and IE but not Firefox, either on Windows or Mac.
Reproducible: Always
Steps to Reproduce:
1. Go to http://www.Google.com/webmasters/%2b1/button/ and generate the code for the Google "+1 Button"
2. Add the code to a page with "<!DOCTYPE html>"
3. Display that page
-- or --
1. simply go to http://www.ExampleOnly.com/plusone/test.html
Actual Results:
Google "+1 Button" is not displayed.
Expected Results:
Google "+1 Button" should be displayed like it does in other major browsers.
|
||
Comment 1•14 years ago
|
||
When I load the exampleonly page, I get this in the console:
[15:05:12.288] Exception when calling callback "open" with exception "[Exception... "An invalid or illegal string was specified" code: "12" nsresult: "0x8053000c (NS_ERROR_DOM_SYNTAX_ERR)" location: "https://ssl.gstatic.com/webclient/js/21550740_8d71de52/client.js Line: 1"]". @ https://ssl.gstatic.com/webclient/js/21550740_8d71de52/client.js:8
The code's minified, and I don't have a debuggable browser to examine further, so I'll leave it at that. But a DOM syntax error seems extremely unlikely to be a JS engine bug. I'm betting TE, but without more analysis it's impossible to say for sure.
|
||
Comment 2•14 years ago
|
||
Rob, would you be able to get us a regression range on this using nightly builds?
Status: UNCONFIRMED → NEW
Ever confirmed: true
|
|
||
Comment 3•14 years ago
|
||
> 1. simply go to http://www.ExampleOnly.com/plusone/test.html
Shows nothing for me in Chrome.
Also, I don't see the comment 1 exception on that page; I just see an XML well-formedness error (presumably for something that the page fetches via XHR).
On the other hand, following steps 1-3 for creating a page worksforme in both Firefox 4 and trunk. But I created an _HTML_ page, not XHTML. I'll attach it here.
|
|
||
Comment 4•14 years ago
|
||
|
|
||
Comment 5•14 years ago
|
||
Note that the plusone code sets innerHTML to a string that is not well-formed XML, which is why you could be seeing issues trying to use it in an XML page.
>> Rob, would you be able to get us a regression range on this using nightly builds?
I just have the end-user versions of Firefox, and I don't even think it may be a regression, and even if it was doubt it would be since Firefox 4. The error Jeff Walden posted seems like it may indicate there's something awry in the Google JavaScript code. I found a post in the Google webmaster forum and I'll try to follow up there first.
|
Assignee | |
Updated•11 years ago
|
Assignee: general → nobody
No longer accessible
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → INCOMPLETE
You need to log in
before you can comment on or make changes to this bug.
Description
•