buildbot should set status to RETRY for upload failures

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: bhearsum, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
We didn't retry when a bunch of bulids failed like this:
make[1]: Entering directory `/builds/slave/cen-lnx/build/obj-firefox/browser/installer'
CHECKSUM FILE START
228daeb6a0cd24abdc1d6786a00be706cc7e31f074cf8fb2ab81d5f2dde9b363ebd5d1e9269f6c579e0ce6146a62d7335d476cf9c32f710699d935078eb2865b sha512 15202599 firefox-7.0a1.en-US.linux-i686.tar.bz2
011de9fe59ff0eacd59a1f1386f769a7e572ceeb9e40a7b47d1e24d539abc23c8f3ac1e61eab067bf4d6177818b7d8fc739353705efb54d7305ae917013eb526 sha512 217725 linux-i686/xpi/firefox-7.0a1.en-US.langpack.xpi
5518b664afebf10e58f936d7e4efe5c97b2b65fa79dc4fe89a2bcbcd75c77303b97965ea6b627e17ebd643677109641dff3b8cd1cf394e25da13363be994c43d sha512 48408138 firefox-7.0a1.en-US.linux-i686.tests.zip
f3bc1346e8b7883cfa5ed19ec4023775606b1e55fbd1a5fb5650a9e96d3592957187b4f688222ba88ffb768fd689b0a0b142f7b4c30e180f83c3b1b25984ec20 sha512 20956700 firefox-7.0a1.en-US.linux-i686.crashreporter-symbols.zip
72ff2f01f8229774d9eb758effa5b9bc1857625cb3865b7bbfe0f973b405254420d328c00821015cd78c0e1f2a03901e4af098661f32917053c34dc916336e5e sha512 70 firefox-7.0a1.en-US.linux-i686.txt
CHECKSUM FILE END
/tools/python/bin/python2.5 /builds/slave/cen-lnx/build/build/upload.py --base-path ../../dist \
		"../../dist/firefox-7.0a1.en-US.linux-i686.tar.bz2"   "../../dist/linux-i686/xpi/firefox-7.0a1.en-US.langpack.xpi"  "../../dist/firefox-7.0a1.en-US.linux-i686.tests.zip" "../../dist/firefox-7.0a1.en-US.linux-i686.crashreporter-symbols.zip"  "../../dist//firefox-7.0a1.en-US.linux-i686.txt"  \
		"../../dist//firefox-7.0a1.en-US.linux-i686.checksums"
ssh: connect to host stage.mozilla.org port 22: Connection timed out
Command ['ssh', '-o', 'IdentityFile=~/.ssh/ffxbld_dsa', 'ffxbld@stage.mozilla.org', 'mktemp -d'] returned non-zero exit code: 255
make[1]: *** [upload] Error 2
make[1]: Leaving directory `/builds/slave/cen-lnx/build/obj-firefox/browser/installer'
make: *** [upload] Error 2
program finished with exit code 2

Related, but not exactly the same as bug 613953, which talks about using retry.py to retry uploads mid-build.
(Assignee)

Updated

7 years ago
Assignee: nobody → bhearsum
(Assignee)

Comment 1

7 years ago
Created attachment 537186 [details] [diff] [review]
catch upload errors, set status to RETRY
Attachment #537186 - Flags: review?(rail)
Attachment #537186 - Flags: review?(rail) → review+
(Assignee)

Comment 2

7 years ago
Comment on attachment 537186 [details] [diff] [review]
catch upload errors, set status to RETRY

Landed on default.
Attachment #537186 - Flags: checked-in+
(Assignee)

Comment 3

7 years ago
This went to production today.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.