661412 - Update telemetry memory reporters

Status: RESOLVED FIXED

(Toolkit :: General, defect)

Description

[(dormant account)]

Attachment: updated probes

about:memory recently changed. Telemetry can no longer find memory fields it's looking for. I also updated the ranges to match what people were submitting.

Comment 1

[Nicholas Nethercote [inactive]]

Comment on attachment 536778 [details] [diff] [review]
updated probes

Review of attachment 536778 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine.  BTW, I personally think the two most interesting measurements are "explicit" and "resident";
bug 660731 is open to make them easier to get from JS code.

Comment 2

[(dormant account)]

Replaced heap-used with resident. Can add explicit once that lands.

http://hg.mozilla.org/mozilla-central/rev/fabceeb16a3d

Comment 3

[Daniel C]

+  "explicit/layout/all": [1024, 64 * 1025, 10]

Should that be 64 * 1024?

Comment 4

[(dormant account)]

(In reply to comment #3)
> +  "explicit/layout/all": [1024, 64 * 1025, 10]
> 
> Should that be 64 * 1024?

yup, fixed that in the above commit

Comment 5

[Daniel C]

(In reply to comment #4)
> (In reply to comment #3)
> > +  "explicit/layout/all": [1024, 64 * 1025, 10]
> > 
> > Should that be 64 * 1024?
> 
> yup, fixed that in the above commit

I can't see where you changed it.

http://mxr.mozilla.org/mozilla-central/source/toolkit/components/telemetry/TelemetryPing.js#59

  "explicit/layout/all": [1024, 64 * 1025, 10]

Comment 6

[(dormant account)]

Sorry. Looks like I only fixed it locally here. I'll fix it in the next set of telemetry patches. Thanks for doublechecking.