661609 - Linux3.0.mk missing in security/coreconf for upcoming 3.0 kernel

Status: RESOLVED FIXED

(NSS :: Build, defect, P2)

Description

[Octoploid]

User-Agent:       Mozilla/5.0 (X11; Linux x86_64; rv:7.0a1) Gecko/20100101 Firefox/7.0a1
Build Identifier: 

Linux3.0.mk is missing in security/coreconf and the build
fails because of this on the upcoming 3.0 Linux kernel.
Simply copying Linux2.6.mk to Linux3.0.mk fixes the problem.

Reproducible: Always

Comment 1

[Mike Hommey [:glandium]]

Another linux 3.0 related problem:
http://mxr.mozilla.org/mozilla-central/source/security/coreconf/Linux.mk#172

Comment 2

[Mike Hommey [:glandium]]

Note that copying the file won't scale, because the next version after 3.0 will be 3.1... which, but the current way the .mk file is picked would mean having to copy again to Linux3.1.mk.

Comment 3

[Yaroslav Fedevych]

I think Linus is right about version numbers here.

https://lkml.org/lkml/2011/6/14/293

May sound relevant to anyone who's going to fix this for good: just have Linux.mk for generic Linux, and Linux<version>.mk for whatever might require quirks.

Comment 4

[Robert Kaiser]

I just ran into this after updating to a 3.0-rc2 kernel:

../coreconf/config.mk:71: ../coreconf/Linux3.0.mk: No such file or directory
gmake[6]: warning: -jN forced in submake: disabling jobserver mode.
gmake -j1: *** No rule to make target ../coreconf/Linux3.0.mk.  Stop.
gmake[6]: *** [../coreconf/Linux3.0.mk] Error 1

(In reply to comment #3)
> May sound relevant to anyone who's going to fix this for good: just have
> Linux.mk for generic Linux, and Linux<version>.mk for whatever might require
> quirks.

That's always a good idea.

Comment 5

[Mike Hommey [:glandium]]

Attachment: Possible patch

Something like this should work, and we can remove all remaining Linux*.mk files, which basically all contain the same thing. I think we can stop caring about Linux 1.2 and 2.0...

Comment 6

[Robert Kaiser]

This affects all channels currently in production, we fail to compile on all of them on system where Linux 3.* kernels are used, which currently are only bleeding edge testers, but soon will be development distros, and in the next months probably also released distros.

Comment 7

[Asa Dotzler [:asa]]

Please request approval for Aurora when this patch has been reviewed. Thanks.

Comment 8

[Robert Kaiser]

Can we please get this review done?
This will mean brokenness for Linux mainline soon, and we also need to get it uplifted through Mozilla branches/channels. We really shouldn't have this rotting here.
I can confirm that the patch fixes builds.

Comment 9

[Andrew Benton]

The patch works for me too. However, it doesn't work for thunderbird. Is there a similar bug for thunderbird?

Comment 10

[Mike Hommey [:glandium]]

(In reply to comment #9)
> The patch works for me too. However, it doesn't work for thunderbird. Is
> there a similar bug for thunderbird?

Define "it doesn't work for thunderbird"

Comment 11

[Kai Engert [:KaiE:]]

(In reply to comment #7)
> Please request approval for Aurora when this patch has been reviewed. Thanks.

Please note, it's not as simple as that. You cannot patch this in Aurora. The proposed changes are in NSS. So, if you want this fix, we must land it into NSS, then produce a new NSS release, then upgrade Mozilla that that NSS.

Comment 12

[Kai Engert [:KaiE:]]

Mike's patch proposes to remove support for Linux1.2 and Linux2.0

I don't know if that's OK, or if we still must support those platforms.

(If you're in a hurry, I propose a patch that adds support for Linux 3, without dropping older platforms, so nobody is scared of allowing.)

Comment 13

[Kai Engert [:KaiE:]]

Also adding bsmith - This might be a trigger to produce a NSS 3.12.11 release?

Comment 14

[Mike Hommey [:glandium]]

(In reply to comment #12)
> (If you're in a hurry, I propose a patch that adds support for Linux 3,
> without dropping older platforms, so nobody is scared of allowing.)

Be aware that adding a Linux3.0.mk file is doomed to fail in a few months, when Linux 3.1 is released.

Comment 15

[Mike Hommey [:glandium]]

(In reply to comment #11)
> (In reply to comment #7)
> > Please request approval for Aurora when this patch has been reviewed. Thanks.
> 
> Please note, it's not as simple as that. You cannot patch this in Aurora.
> The proposed changes are in NSS. So, if you want this fix, we must land it
> into NSS, then produce a new NSS release, then upgrade Mozilla that that NSS.

Note that there have been patched nss in the mozilla tree in the past. Actually, it appears to be patched at the moment.

Comment 16

[Kai Engert [:KaiE:]]

I just received an opinion from Wan-Teh:
  "It is fine to remove Linux1.2.mk and Linux2.0.mk."

Comment 17

[Brian Smith (:briansmith, :bsmith, use NEEDINFO?)]

Mike, does the rest of mozilla-central build OK on kernel 3.0, or are there other problems besides NSS?

FWIW, the patch that is in m-c for NSS will get backed out right after the Aurora merge. It is there to help with finding a bug in NSS, and it isn't intended for any release.

The patch is easier to review if you understand that the meat of Linux.2.6.mk was appended to the bottom of Linux.mk, and then the check for Linux 2.4 was appended to that. (Do a visual diff of the patched Linux.mk to Linux.2.6.mk before deleting Linux.2.6.mk). In addition to this patch, Linux2.*.mk must be deleted. Based on Kai's latest comment, this seems like a good change.

I am not opposed to putting this change in m-c after the next Aurora merge (this upcoming Tuesday) until the next NSS release, as I am guessing that many people hacking on Firefox will be early adopters of the new Linux kernel, and this would disrupt their work. But, we don't need to bother unless/until this is the only thing stopping Firefox from building on kernel 3.0. Official NSS and Firefox releases are going to be built using older 2.6 kernels anyway, so the most important thing to do is verify that these changes don't have any (negative) effect when building with a 2.6.x kernel.

Comment 18

[Robert Kaiser]

(In reply to comment #17)
> Mike, does the rest of mozilla-central build OK on kernel 3.0, or are there
> other problems besides NSS?

I'm not Mike, but I have successfully compiled Firefox, SeaMonkey (opt and debug) and Thunderbird based on mozilla-central with only this patch applied and on a Linux 3.0-rc4 system. I've also run the Firefox and SeaMonkey builds from this compile run without problems. So it looks like this patch is all that's needed.

Comment 19

[Robert Kaiser]

(In reply to comment #17)
> Official NSS and Firefox releases are going to be built using older 2.6
> kernels anyway, so the most important thing to do is verify that these
> changes don't have any (negative) effect when building with a 2.6.x kernel.

Oh, missed that when writing the last comment - If we don't uplift this build-only patch that doesn't change actual code (IIUC) to Firefox 6, then we should reach out to the Linux distro people to tell them they need to apply it when they want to offer builds on systems with a 3.0 (or higher) kernel.

Comment 20

[Mike Hommey [:glandium]]

(In reply to comment #17)
> In addition to this patch, Linux2.*.mk must be deleted.

Linux*.mk, even.

Comment 21

[Wan-Teh Chang]

Attachment: Proposed patch by Mike Hommey, part 1

To make it easy to review the important changes, I put the
removal of Linux*.mk in a separate patch.

Patches checked in on the NSS trunk (NSS 3.13).

Checking in Linux.mk;
/cvsroot/mozilla/security/coreconf/Linux.mk,v  <--  Linux.mk
new revision: 1.49; previous revision: 1.48
done
Removing Linux2.1.mk;
/cvsroot/mozilla/security/coreconf/Linux2.1.mk,v  <--  Linux2.1.mk
new revision: delete; previous revision: 1.7
done
Removing Linux2.2.mk;
/cvsroot/mozilla/security/coreconf/Linux2.2.mk,v  <--  Linux2.2.mk
new revision: delete; previous revision: 1.7
done
Removing Linux2.4.mk;
/cvsroot/mozilla/security/coreconf/Linux2.4.mk,v  <--  Linux2.4.mk
new revision: delete; previous revision: 1.10
done
Removing Linux2.5.mk;
/cvsroot/mozilla/security/coreconf/Linux2.5.mk,v  <--  Linux2.5.mk
new revision: delete; previous revision: 1.6
done
Removing Linux2.6.mk;
/cvsroot/mozilla/security/coreconf/Linux2.6.mk,v  <--  Linux2.6.mk
new revision: delete; previous revision: 1.6
done
Removing LinuxELF1.2.mk;
/cvsroot/mozilla/security/coreconf/LinuxELF1.2.mk,v  <--  LinuxELF1.2.mk
new revision: delete; previous revision: 1.2
done
Removing LinuxELF2.0.mk;
/cvsroot/mozilla/security/coreconf/LinuxELF2.0.mk,v  <--  LinuxELF2.0.mk
new revision: delete; previous revision: 1.2
done
Checking in config.mk;
/cvsroot/mozilla/security/coreconf/config.mk,v  <--  config.mk
new revision: 1.31; previous revision: 1.30
done

Comment 22

[Wan-Teh Chang]

Attachment: Proposed patch part 2

cvs remove the following files in mozilla/security/coreconf:
Linux2.1.mk
Linux2.2.mk
Linux2.4.mk
Linux2.5.mk
Linux2.6.mk
LinuxELF1.2.mk
LinuxELF2.0.mk

Comment 23

[Wan-Teh Chang]

Attachment: Proposed patch part 1 for NSS_3_12_BRANCH

The Linux.mk patch for NSS_3_12_BRANCH is slightly different
because the NO_FORK_CHECK code at the end of Linux2.4.mk is
different.

Patches checked in on the NSS_3_12_BRANCH (NSS 3.12.11).

Checking in Linux.mk;
/cvsroot/mozilla/security/coreconf/Linux.mk,v  <--  Linux.mk
new revision: 1.45.2.3; previous revision: 1.45.2.2
done
Removing Linux2.1.mk;
/cvsroot/mozilla/security/coreconf/Attic/Linux2.1.mk,v  <--  Linux2.1.mk
new revision: delete; previous revision: 1.7
done
Removing Linux2.2.mk;
/cvsroot/mozilla/security/coreconf/Attic/Linux2.2.mk,v  <--  Linux2.2.mk
new revision: delete; previous revision: 1.7
done
Removing Linux2.4.mk;
/cvsroot/mozilla/security/coreconf/Attic/Linux2.4.mk,v  <--  Linux2.4.mk
new revision: delete; previous revision: 1.9
done
Removing Linux2.5.mk;
/cvsroot/mozilla/security/coreconf/Attic/Linux2.5.mk,v  <--  Linux2.5.mk
new revision: delete; previous revision: 1.6
done
Removing Linux2.6.mk;
/cvsroot/mozilla/security/coreconf/Attic/Linux2.6.mk,v  <--  Linux2.6.mk
new revision: delete; previous revision: 1.6
done
Removing LinuxELF1.2.mk;
/cvsroot/mozilla/security/coreconf/Attic/LinuxELF1.2.mk,v  <--  LinuxELF1.2.mk
new revision: delete; previous revision: 1.2
done
Removing LinuxELF2.0.mk;
/cvsroot/mozilla/security/coreconf/Attic/LinuxELF2.0.mk,v  <--  LinuxELF2.0.mk
new revision: delete; previous revision: 1.2
done
Checking in config.mk;
/cvsroot/mozilla/security/coreconf/config.mk,v  <--  config.mk
new revision: 1.30.2.1; previous revision: 1.30
done

Comment 25

[Kai Engert [:KaiE:]]

patch is checked in, marking fixed.

Comment 26

[Frederic Bezies]

Cannot get firefox compiled with linux 3.0 on archlinux :

nsINativeAppSupport.idl
../coreconf/config.mk:71: ../coreconf/Linux3.0.mk: Aucun fichier ou dossier de ce type
make[6]: AVERTISSEMENT : -jN forcé dans un submake : désactivation du mode serveur de tâches.
make -j1: *** No rule to make target ../coreconf/Linux3.0.mk.  Stop.
make[6]: *** [../coreconf/Linux3.0.mk] Erreur 1
make[5]: *** [libs] Erreur 2
make[4]: *** [libs_tier_platform] Erreur 2
make[3]: *** [tier_platform] Erreur 2
make[2]: *** [default] Erreur 2
make[1]: *** [realbuild] Erreur 2
make: *** [build] Erreur 2

Comment 27

[Mike Hommey [:glandium]]

That's because the change didn't land in firefox yet.

Comment 29

[20ac93a2]

I'm running Slackware 13.37 and I grabbed 6.0.1 and it appears that these patches are already applied to that version because it says, Reversed (or previously applied) patch detected! 

Anyhow I am getting this problem with this version of Firefox with the 3.0.4 kernel, I can't compile Firefox, so we still have this problem...

So this isn't resolved or fixed, please reopen....


THANKS

Comment 30

[20ac93a2]

By the way I forgot to ask, but I take it that all 3 patches are suppose to be used?

Proposed patch by Mike Hommey, part 1 (2.12 KB, patch)

Proposed patch part 2 (15.95 KB, patch)

Proposed patch part 1 for NSS_3_12_BRANCH (2.29 KB, patch)


THANKS

Comment 31

[Mike Hommey [:glandium]]

No, you only need one part 1 depending on the nss version. And I seriously doubt that it isn't resolved.

Comment 32

[20ac93a2]

Well it hasn't been resolved in FF 6.0.1 it still needs a patch applied against it.

Which par 1 there are two. ;)

Mike's or the nss one?


THANKS

Comment 33

[20ac93a2]

Well it hasn't been resolved in FF 6.0.1 it still needs a patch applied against it.

Which part 1 there are two. ;)

Mike's or the nss one?


THANKS

Comment 34

[20ac93a2]

Errr thought it removed one of the comments, sorry hit the button by mistake over...

Comment 35

[Robert Kaiser]

AFAIK, this is only fixed in Firefox 8, so 6 as well as 7 need to be manually patched with attachment 543656 [details] [diff] [review] to be able to build on a system with kernel 3.0 or higher.

Comment 36

[20ac93a2]

I used for Firefox 6.0.1 Proposed patch by Mike Hommey, part 1 patch and it compiled ok... :)

Fixed in Firefox 8, LOL, boy someone over at Mozilla is certainly rushing through the versions...

What's with the version rush all of a sudden? 3.x never moved this fast...


THANKS

Comment 38

[u43589]

Its ironic how pointless changes in version-schemes breaks stuff...

Comment 39

[Felix Möller]

I just hit this issue when trying to build Thunderbird from comm-beta on a 3.0 kernel.