661647 - compare(String,String) optimizations don't happen on 64-bit

Status: RESOLVED WONTFIX

(Tamarin Graveyard :: Baseline JIT (CodegenLIR), defect, P3)

Description

[Edwin Smith]

This logic uses LIR_calli to detect string,string comparisons involving String.charAt(), but since the helper functions return string pointers, the check should be LIR_callp.  Basically these optimizations are disabled on x64.

  if (lht == STRING_TYPE && rht == STRING_TYPE) {
    if (localGetp(lhsi)->opcode() == LIR_calli) {
      LIns* result = optimizeStringCmpWithStringCall(lhsi, rhsi, icmp, false);
      if (result)
        return result;
    }
    else if (localGetp(rhsi)->opcode() == LIR_calli) {
      LIns* result = optimizeStringCmpWithStringCall(rhsi, lhsi, icmp, true);
      if (result)
        return result;
    }
  }

Comment 1

[Edwin Smith]

I targeted Serrano just to get it through the decision process, but if not Serrano, I recommend Anza -- low hanging fruit, why wait.

Comment 2

[Edwin Smith]

Attachment: WIP, needs testing