Closed Bug 661652 Opened 13 years ago Closed 13 years ago

Annotator's text content has become invisible in 1.0RC

Categories

(Add-on SDK Graveyard :: Documentation, defect, P1)

Product:
Add-on SDK Graveyard
Component:
Documentation
Platform:
x86
macOS
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: wbamberg, Assigned: irakli)

References

Details

Attachments

(3 files)

Do not add style when a background-color is set
2.92 KB, patch
Details | Diff | Splinter Review
Add color definication in annotator
844 bytes, patch
Details | Diff | Splinter Review
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/181
355 bytes, text/html
myk
: review+
Details 
I assume as a side-effect of bug 652548, normal text is now (almost?) exactly the same color as the background in panels, so you can't see it. This:

body
  {
  background-color: #F5F5F5;
+ color: black;
  font: 100% arial, helvetica, sans-serif;
  }

is enough to fix the immediate problem, but is this indicative of a more general problem here?
Assignee: nobody → myk
Priority: -- → P1
Target Milestone: --- → 1.0
This style trick is very weak and we may enforce users to take care of background/colors. May be in documentation?
Nevertheless here is a way to improve it. We do not add a text color when a background color is set. Note that it may still be broken on sub-styles. (the style is applied on <body> but a background can be set on a <div> without a color)
Assignee: myk → poirot.alex
Attachment #537554 - Flags: review?(myk)
Or we can just add color to annotator example.
Attachment #537556 - Flags: review?(myk)
Assignee: poirot.alex → rFobic
Comment on attachment 537557 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/181

Apparently Alex was working on this as well, but I did diff thing so still attaching this one. I reset styles to defaults so that panel / text looks native across diff platforms. Also I think it's better to have example showing how to make platform independent panel rather than making it white white.
Attachment #537557 - Flags: review?(myk)
Comment on attachment 537557 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/181

Yup, this looks like the right solution.
Attachment #537557 - Flags: review?(myk) → review+
Attachment #537554 - Flags: review?(myk)
Attachment #537556 - Flags: review?(myk)
https://github.com/mozilla/addon-sdk/commit/8ff54666fbc53e7d57942680aed3edc8fff82d5a
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: