661688 - Make left-hand column of file viewer stay on the top left when scrolling down

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, enhancement, P3)

Description

[Jorge Villalobos [:jorgev] (he/him)]

Since the new file viewer doesn't have a vertical scrollbar for the code section, long files can be a navigational inconvenience, because you have to scroll all the way up to select the next file (or remember the shortcuts).

I think it would be nice to have the left panel move to keep its top left position, similarly to what it done with the right-hand panel in review pages.

Comment 1

[Wil Clouser [:clouserw]]

gkoberger did this on the review pages if you want to steal code

Comment 2

[Andy McKay]

I think this implies pushing the left hand nav into a fixed height and giving it scroll bars, something I was hoping to avoid. Otherwise it would be hard to get down a fully expanded tree (https://addons.mozilla.org/en-US/firefox/files/121418) for example.

Comment 3

[Jorge Villalobos [:jorgev] (he/him)]

The alternative would be make the code scrollable independently from the page.

Comment 4

[Wil Clouser [:clouserw]]

(In reply to comment #2)
> I think this implies pushing the left hand nav into a fixed height and
> giving it scroll bars, something I was hoping to avoid. Otherwise it would
> be hard to get down a fully expanded tree
> (https://addons.mozilla.org/en-US/firefox/files/121418) for example.

I think you could do it without a fixed height, but I'm not sure if it would be confusing.  Scroll down would scroll everything until it hit nav.bottom and then it would move down the page, scroll up would scroll everything until it hit nav.top and then move up the page with the scroll.  Too confusing?

Maybe chowse has an idea.

Comment 5

[Kris Maglione [:kmag]]

I think having a max-height and overflow:auto on the file list would be the best thing here. Using some aspect of the page scrolling to determine which bit of the file list in view seems wrong. Aside from being confusing, it would require even more inconvenient scrolling to get to the file you're after than we have now.

Comment 6

[Kris Maglione [:kmag]]

I'll have a patch for this when 663254 is merged.

Comment 7

[Kris Maglione [:kmag]]

Screenshots in case anyone has any input before I finish:

File tree visible:

    http://666kb.com/i/bvyt6nfiys8bss2if.png
    http://666kb.com/i/bvyt68g523ufdvxdj.png
    http://666kb.com/i/bvyt748vto50in6pj.png

File tree hidden:

    http://666kb.com/i/bvyt8kt8planrsv5j.png
    http://666kb.com/i/bvyt9y0vc9pa2dkmv.png

Comment 8

[Kris Maglione [:kmag]]

https://github.com/mozilla/zamboni/pull/270

Comment 9

[Christopher Van Wiemeersch [:cvan]]

Merged: https://github.com/mozilla/zamboni/commit/9395dae

Comment 10

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/44715ac

Comment 11

[Jorge Villalobos [:jorgev] (he/him)]

Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...