661770 - TM: inline Atomize into js_AtomizeChars

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Chris Leary [:cdleary] (not checking bugmail)]

Attachment: Inline Atomize into js_AtomizeChars.

This Atomize interface is super hot through getTokenInternal, and valgrind likes the results on parsemark for x86.

Comment 1

[Chris Leary [:cdleary] (not checking bugmail)]

Attachment: Valgrind diff results.

Comment 2

[Chris Leary [:cdleary] (not checking bugmail)]

Attachment: Make shell's |compile| function compile-and-go.

I'm hoping to get this one as a ride-along, since I use it to measure the valgrind diff results. A bunch of things change about the parse routine for compile-and-go, one example being use of the globalMap to understand global index slots for property accesses. Since parsing content works this way, I think the shell should work this way as well. Maybe we could make it an option later if we find that necessary (and maybe let users pass a JSObject to use as a fake global?), but I think the default being compile and go is more reflective of what we'd like to optimize.

Comment 3

[Nicholas Nethercote [inactive]]

Comment on attachment 537104 [details] [diff] [review]
Inline Atomize into js_AtomizeChars.

Review of attachment 537104 [details] [diff] [review]:
-----------------------------------------------------------------

Comment 4

[Nicholas Nethercote [inactive]]

Comment on attachment 537107 [details] [diff] [review]
Make shell's |compile| function compile-and-go.

Review of attachment 537107 [details] [diff] [review]:
-----------------------------------------------------------------

I don't understand compile-and-go well enough to review this.  Maybe Luke can review?

Comment 5

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/tracemonkey/rev/eac7f013bacc
http://hg.mozilla.org/tracemonkey/rev/3ab18e7ea3d5

Comment 6

[Chris Leary [:cdleary] (not checking bugmail)]

http://hg.mozilla.org/mozilla-central/rev/eac7f013bacc
http://hg.mozilla.org/mozilla-central/rev/3ab18e7ea3d5