66181 - Content-Disposition filename with quotes is parsed wrong

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect)

Description

[Stanislav Malyshev]

When I use Content-Disposition header for HTTP response, and give a filename as
a quoted string (according to RFC2183, filename can be given as filename=value,
where value is token or quoted-string), the file that user gets offered for
downlaod, contains double quotes.
I think Mozilla should detect this situation and strip the quotes.

Test case: connect with Mozilla to a socket, and give as a response header:

HTTP/1.1 200 OK
Content-type: application/x-msdos-program
Content-Disposition: inline; filename="test.txt"
Content-Length: 20
Connection: close

You will see that you are offered to download file "test.txt" - with quotes!

Comment 1

[Darin Fisher]

nominating for moz 0.9

Comment 2

[Darin Fisher]

added keyword nsbeta1

Comment 3

[Darin Fisher]

Attachment: Patch for uriloader/exthandler/nsExternalHelperAppService.cpp

Comment 4

[Darin Fisher]

Scott, can you r/sr this patch?  Thanks!

Comment 5

[Gagan]

r=gagan

Comment 6

[Scott MacGregor]

*doh* that's my bad. thanks darin.
sr=mscott

Comment 7

[Darin Fisher]

Patch checked in.

Comment 8

[benc]

+verifyme: Tom, do you think our customizable HTTP test server can do this?

Comment 9

[Tom Everingham]

Ben, yeah, the internal testcase is 01ContentDisposition 

verified:  6/27 branch and trunk, all platforms