823 bytes, patch
|Details | Diff | Splinter Review|
When I use Content-Disposition header for HTTP response, and give a filename as a quoted string (according to RFC2183, filename can be given as filename=value, where value is token or quoted-string), the file that user gets offered for downlaod, contains double quotes. I think Mozilla should detect this situation and strip the quotes. Test case: connect with Mozilla to a socket, and give as a response header: HTTP/1.1 200 OK Content-type: application/x-msdos-program Content-Disposition: inline; filename="test.txt" Content-Length: 20 Connection: close You will see that you are offered to download file "test.txt" - with quotes!
nominating for moz 0.9
Target Milestone: --- → mozilla0.9
added keyword nsbeta1
Created attachment 26635 [details] [diff] [review] Patch for uriloader/exthandler/nsExternalHelperAppService.cpp
Scott, can you r/sr this patch? Thanks!
Keywords: nsbeta1 → nsbeta1+
*doh* that's my bad. thanks darin. sr=mscott
Patch checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
+verifyme: Tom, do you think our customizable HTTP test server can do this?
Ben, yeah, the internal testcase is 01ContentDisposition verified: 6/27 branch and trunk, all platforms
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.