Content-Disposition filename with quotes is parsed wrong

VERIFIED FIXED in mozilla0.9

Status

()

Core
Networking: HTTP
VERIFIED FIXED
18 years ago
17 years ago

People

(Reporter: Stanislav Malyshev, Assigned: Darin Fisher)

Tracking

({verifyme})

Trunk
mozilla0.9
x86
Linux
verifyme
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

18 years ago
When I use Content-Disposition header for HTTP response, and give a filename as
a quoted string (according to RFC2183, filename can be given as filename=value,
where value is token or quoted-string), the file that user gets offered for
downlaod, contains double quotes.
I think Mozilla should detect this situation and strip the quotes.

Test case: connect with Mozilla to a socket, and give as a response header:

HTTP/1.1 200 OK
Content-type: application/x-msdos-program
Content-Disposition: inline; filename="test.txt"
Content-Length: 20
Connection: close

You will see that you are offered to download file "test.txt" - with quotes!
(Assignee)

Updated

18 years ago
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 1

18 years ago
nominating for moz 0.9
Target Milestone: --- → mozilla0.9
(Assignee)

Comment 2

17 years ago
added keyword nsbeta1
Keywords: nsbeta1
(Assignee)

Comment 3

17 years ago
Created attachment 26635 [details] [diff] [review]
Patch for uriloader/exthandler/nsExternalHelperAppService.cpp
(Assignee)

Comment 4

17 years ago
Scott, can you r/sr this patch?  Thanks!

Comment 5

17 years ago
r=gagan
Keywords: nsbeta1 → nsbeta1+

Comment 6

17 years ago
*doh* that's my bad. thanks darin.
sr=mscott
(Assignee)

Comment 7

17 years ago
Patch checked in.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 8

17 years ago
+verifyme: Tom, do you think our customizable HTTP test server can do this?
Keywords: verifyme

Comment 9

17 years ago
Ben, yeah, the internal testcase is 01ContentDisposition 

verified:  6/27 branch and trunk, all platforms
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.