deployer scripts for android and ssh can fail to determine deployed revision

VERIFIED FIXED

Status

Tamarin
Build Config
VERIFIED FIXED
7 years ago
7 years ago

People

(Reporter: Brent Baker, Unassigned)

Tracking

unspecified
Bug Flags:
flashplayer-bug -
flashplayer-triage +

Details

(Whiteboard: buildbot)

Attachments

(1 attachment)

(Reporter)

Description

7 years ago
Created attachment 537133 [details] [diff] [review]
update awk statement to print the last string

There is logic in the remote deployer scripts that attempt to make sure that the deployed revision on the remote machine is what was requested. This is currently fragile since it assumes that the revision string contains 6 strings, but this is not always true. When the shell is compiled from P4 source it contains 7 strings. So instead of using a string index, just get the last string which is the revision.

"avmplus shell 2.0 debug-debugger build 22:7f2a7e88d19f"
Attachment #537133 - Flags: review?(cpeyer)
Flags: flashplayer-triage+
Flags: flashplayer-bug-
(Reporter)

Comment 1

7 years ago
Comment on attachment 537133 [details] [diff] [review]
update awk statement to print the last string

This patch should land in both tr and tr-serrano

Updated

7 years ago
Attachment #537133 - Flags: review?(cpeyer) → review+

Comment 2

7 years ago
changeset: 6377:2d6d4e93737b
user:      Brent Baker <brbaker@adobe.com>
summary:   Bug 661811: deployer scripts for android and ssh can fail to determine deployed revision (r=cpeyer)

http://hg.mozilla.org/tamarin-redux/rev/2d6d4e93737b
(Reporter)

Comment 3

7 years ago
tamarin-redux-serrano

changeset: 6305:6dd6e4ad6854
user:      Brent Baker <brbaker@adobe.com>
date:      Mon Jun 06 07:02:00 2011 -0400
description:
Bug 661811: deployer scripts for android and ssh can fail to determine deployed revision (r=cpeyer)
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Updated

7 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.