661871 - Fennec beta builds will not install via automation

Status: RESOLVED WONTFIX

(Release Engineering :: General, defect)

Description

[cmtalbert]

For automation purposes we need the builds to be all signed with the nightly key, but it looks like there is a different key being used for the android beta builds, which breaks the test automation.

If you extract a beta apk and an aurora apk, you'll find the following:
ctalbert@ctalbert-VirtualBox:~/projects/build/fennec_tmp/f_aurora/META-INF$ diff NIGHTLY.DSA ../../fennec_beta_apk/META-INF/NIGHTLY.DSA
Binary files NIGHTLY.DSA and ../../fennec_beta_apk/META-INF/NIGHTLY.DSA differ
ctalbert@ctalbert-VirtualBox:~/projects/build/fennec_tmp/f_aurora/META-INF$ 

We'd expect those to be the same if they were signed with the same key.

Since we're talking about signing and keys I'm going to be conservative and mark this bug confidential.  Not sure if it really should or shouldn't be.

This was found by the automation not having the ability to write to: /data/data/org.mozilla.firefox_beta.

You can test it using that:
1. Install a beta build onto device running agent 1.0
2. Push file to /data/data/org.mozilla.firefox_beta

= Expected =
Push would succeed

= Actual =
Push fails saying "no permission to write to directory"

Comment 1

[Aki Sasaki (not active)]

No worries about making this public.

We've verified that the mozilla-beta tinderbox-builds apks are using the nightly key, via

./build-tools/release/signing/verify-android-signature.sh --apk=http://stage.mozilla.org/pub/mozilla.org/mobile/tinderbox-builds/mozilla-beta-android/1307062773/fennec-5.0.en-US.eabi-arm.apk --tools-dir=/src/android-beta-sig/build-tools --nightly
TOOLS DIR: /src/android-beta-sig/build-tools
Archive:  ./package.apk
  inflating: META-INF/NIGHTLY.DSA    
Valid

(This currently only works in Pacific Time; mjessome is working on fixing that.)

We're still having issues installing it, which may be a different issue. I currently suspect shared id.

Comment 2

[Aki Sasaki (not active)]

http://mxr.mozilla.org/mozilla-beta/source/embedding/android/AndroidManifest.xml.in#8

android:sharedUserId="@ANDROID_PACKAGE_NAME@.sharedID">

It looks like the MOZ_ANDROID_SHARED_ID changes aren't in mozilla-beta.

We should either push the fix there, or resolve WONTFIX and not test mozilla-beta until MOZ_ANDROID_SHARED_ID is there.

Comment 3

[Aki Sasaki (not active)]

Looked at http://mxr.mozilla.org/mozilla-central/source/embedding/android/Makefile.in#101 to make sure that we're good.

When these changes make it to mozilla-beta, we'll be using either org.mozilla.fennec.sharedID or org.mozilla.firefox.sharedID depending on whether we're looking at a tinderbox-builds or candidates for mozilla-beta, so comment 2 holds true.

Comment 4

[Aki Sasaki (not active)]

These changes are also on mozilla-aurora, so we should be good after the aurora->beta merge in late June.  (Last comment from me for a while, sorry)

Comment 5

[cmtalbert]

(In reply to comment #2)
> http://mxr.mozilla.org/mozilla-beta/source/embedding/android/AndroidManifest.
> xml.in#8
> 
> android:sharedUserId="@ANDROID_PACKAGE_NAME@.sharedID">
> 
> It looks like the MOZ_ANDROID_SHARED_ID changes aren't in mozilla-beta.
> 
> We should either push the fix there, or resolve WONTFIX and not test
> mozilla-beta until MOZ_ANDROID_SHARED_ID is there.

Crap, I was certain I checked that.  I must have looked at the wrong tree and thought I'd looked at beta.  Yeah we should either wontfix this and wait for the next train or we should land that patch on beta.  Finkle: you have an opinion?

Comment 6

[Mark Finkle (:mfinkle) (use needinfo?)]

I don't think we need to rush the sharedID change into beta right now. Let's wait until mozilla-aurora gets pushed into mozilla-beta in late June.

WONTFIX'ing