66190 - External style sheet with unrecognized charset is ignored

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P2)

Description

[Koike Kazuhiko]

If an external style sheet has an illegal charset setting,
the rest of the file is ignored.

Testcase:
http://sites.netscape.net/ikazhik/bugzilla/test/20010122a.html

Build: 2001012008/Win98

Comment 1

[Hixie (not reading bugmail)]

Netscape's standard compliance QA team reorganised itself once again, so taking 
remaining non-tables style bugs. Sorry about the spam. I tried to get this done 
directly at the database level, but apparently that is "not easy because of the 
shadow db", "plus it screws up the audit trail", so no can do...

Comment 2

[Koike Kazuhiko]

CSS2 Specification says "A CSS user agent that encounters an unrecognized
at-rule must ignore the whole of the at-rule and continue parsing after it".

http://www.w3.org/TR/REC-CSS2/syndata.html#at-rules

Comment 3

[Pierre Saslawsky]

Marc, Daniel: please review

Comment 4

[Pierre Saslawsky]

Attachment: patch

Comment 5

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

r=glazman, tested on win2k with provided testcase, but there is now a
useless level of {..} nesting that should be removed at least for readability.

Comment 6

[Pierre Saslawsky]

This fix should be checked in together with the patch that I'm going to attach to 
bug 63502.

Comment 7

[Marc Attinasi]

Do you really want to ignore ALL erroes from SetCharset? If so, please put a
comment explaining why - Thanks. sr=attinasi

Comment 8

[Pierre Saslawsky]

I considered the cases where the returned code would be something else than 
"charset not found", like "out of memory" or "i18n library not loaded", but the 
only purpose of SetCharset() is to initialize a member variable (nsString 
mCharset) to something else than "ISO-8859-1".  

The spec says that if the charset is not supported, we should continue the 
parsing with "ISO-8859-1".  I interpreted the notion of "charset not supported" 
in its fullest extent.

Comment 9

[Marc Attinasi]

Perfect - please put that comment in the code where the call is made and the
return ignored so others will understand why.

Comment 10

[Pierre Saslawsky]

fixed

Comment 11

[Hixie (not reading bugmail)]

VERIFIED per http://sites.netscape.net/ikazhik/bugzilla/test/20010122a.html