661901 - Hide the list of bugmail recipients by default from users without can-confirm

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: User Interface, enhancement)

Description

[Josh Matthews [:jdm]]

The list of people who have received mail because of a change in a bug can be intimidating to newcomers. Paul brought this up when we were talking, but I doubted him until I saw this conversation in #introduction:

14:42 < foo> hi.  I have an end-user question: how can I *quietly* follow a bug by email?      
14:43 < foo> I checked "Add me to CC list", pressed "Save Changes", and was horrified to see "Email sent to: [biglist]"

I have found the list to be useful on occasion, but certainly the majority of the time it's just wasted space. If there were some way to hide it in a collapsible div that could be toggled open, that might be a good solution for a potential stumbling block for newcomers.

Comment 1

[Reed Loden [:reed]]

Except that just creates more work for those of us who always want to see the list of addresses. Maybe a user setting? Or dependent on whether the user has canconfirm or not?

Comment 2

[David Lawrence [:dkl]]

What if we threw all of those recipients into hidden divs with a link/button to
make them all appear if the user desires? It would be one extra click only for those who are interested in that sort of thing, but hidden out of the way for those who are not. Would be simple to write up.

dkl

Comment 3

[Josh Matthews [:jdm]]

dkl, that sounds exactly like my proposal. Reed, maybe we could set a cookie that could control the default value and gets updated whenever you change that visibility state.

Comment 4

[Dave Miller [:justdave]]

Could show it by default for people with canconfirm and hide it by default for people without canconfirm.  Usually people would know what was going on by the time they get canconfirm privs.

Comment 5

[:glob ✱]

Attachment: patch v1

this patch implements justdave's suggestion -- the list of recipients are hidden by default if you don't have canconfirm. users with canconfirm continue to be shown the recipient list.

Comment 6

[:glob ✱]

Attachment: screenshot

Comment 7

[David Lawrence [:dkl]]

Comment on attachment 574845 [details] [diff] [review]
patch v1

Review of attachment 574845 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good to me and works as expected. r=dkl

::: template/en/default/bug/process/bugmail.html.tmpl
@@ +33,5 @@
> +     || !user.can_see_bug(mailing_bugid)
> +%]
> +
> +<dl id="bugmail_summary_[% mailing_bugid FILTER none %]"
> +    [%~ ' class="bz_default_hidden"' UNLESS show_recipients %]>

As an alternative you could do:

<dl id="bugmail_summary_[% mailing_bugid FILTER none %]"
    [%= 'class="bz_default_hidden"' UNLESS show_recipients %]>

'=' removes all whitespace but leaves one space so looks slightly cleaner. But the way you have it works as well.

Comment 8

[Josh Matthews [:jdm]]

Was this forgotten?

Comment 9

[:glob ✱]

it was committed and has been live for a while; http://bzr.mozilla.org/bmo/4.0/revision/7949

thanks jdm :)