GCC 4.6 build warning: "nsIOService.cpp:432:12: warning: variable ‘listedProtocol’ set but not used"

RESOLVED FIXED in mozilla7

Status

()

Core
Networking
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: dholbert, Assigned: dholbert)

Tracking

Trunk
mozilla7
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
When building with GCC 4.6:
{
netwerk/base/src/nsIOService.cpp:432:12: warning: variable ‘listedProtocol’ set but not used [-Wunused-but-set-variable]
}

From comparing these consecutive revisions...
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/netwerk/base/src/nsIOService.cpp&rev=1.199
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/netwerk/base/src/nsIOService.cpp&rev=1.200
...it looks like revision 200 (bug 391978) removed the last use of this variable.

Seems like we can just remove it completely now.
(Assignee)

Comment 1

6 years ago
Created attachment 537258 [details] [diff] [review]
fix: remove variable
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Attachment #537258 - Flags: review?(bzbarsky)
Comment on attachment 537258 [details] [diff] [review]
fix: remove variable

Oops.  The review comments in bug 391978 had even mentioned this....

r=me
Attachment #537258 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 3

6 years ago
http://hg.mozilla.org/projects/cedar/rev/d9c15147d35d
Whiteboard: [build_warning] → [build_warning][fixed-in-cedar]
http://hg.mozilla.org/mozilla-central/rev/d9c15147d35d
Status: ASSIGNED → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [build_warning][fixed-in-cedar] → [build_warning]
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.