Last Comment Bug 661967 - GCC 4.6 build warning: "nsIOService.cpp:432:12: warning: variable ‘listedProtocol’ set but not used"
: GCC 4.6 build warning: "nsIOService.cpp:432:12: warning: variable ‘listedProt...
Product: Core
Classification: Components
Component: Networking (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla7
Assigned To: Daniel Holbert [:dholbert]
: Patrick McManus [:mcmanus]
Depends on:
Blocks: 391978
  Show dependency treegraph
Reported: 2011-06-03 15:54 PDT by Daniel Holbert [:dholbert]
Modified: 2011-06-08 14:57 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix: remove variable (1.24 KB, patch)
2011-06-03 15:57 PDT, Daniel Holbert [:dholbert]
bzbarsky: review+
Details | Diff | Splinter Review

Description Daniel Holbert [:dholbert] 2011-06-03 15:54:15 PDT
When building with GCC 4.6:
netwerk/base/src/nsIOService.cpp:432:12: warning: variable ‘listedProtocol’ set but not used [-Wunused-but-set-variable]

From comparing these consecutive revisions... looks like revision 200 (bug 391978) removed the last use of this variable.

Seems like we can just remove it completely now.
Comment 1 Daniel Holbert [:dholbert] 2011-06-03 15:57:12 PDT
Created attachment 537258 [details] [diff] [review]
fix: remove variable
Comment 2 Boris Zbarsky [:bz] (still a bit busy) 2011-06-07 01:15:26 PDT
Comment on attachment 537258 [details] [diff] [review]
fix: remove variable

Oops.  The review comments in bug 391978 had even mentioned this....

Comment 3 Daniel Holbert [:dholbert] 2011-06-07 10:52:51 PDT

Note You need to log in before you can comment on or make changes to this bug.