Closed Bug 661972 Opened 13 years ago Closed 13 years ago

Service.sync() still called with fullSync param

Categories

(Firefox :: Sync, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla7

People

(Reporter: rnewman, Assigned: rnewman)

Details

(Whiteboard: [fixed in services][qa-])

Attachments

(1 file)

... even though it was removed back in 2009:

http://hg.mozilla.org/services/fx-sync/diff/80f05b8704a3/source/modules/service.js#l1.101

and never did anything anyway!

   1.105 -    fullSync = true; // not doing thresholds yet
Testing this now.
Assignee: nobody → rnewman
Status: NEW → ASSIGNED
Comment on attachment 537268 [details] [diff] [review]
Proposed patch. v1

Tests pass.
Attachment #537268 - Flags: review?(philipp)
Attachment #537268 - Flags: review?(philipp) → review+
Pushed:

https://hg.mozilla.org/services/services-central/rev/615040e391de
Whiteboard: [fixed in services][qa-]
http://hg.mozilla.org/mozilla-central/rev/615040e391de
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Component: Firefox Sync: Backend → Sync
Product: Cloud Services → Firefox
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: