Port |Bug 608934 - About window needs a close button| to comm-central

RESOLVED FIXED in Thunderbird 7.0

Status

Thunderbird
General
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: Hideo Oshima, Assigned: Takanori MATSUURA)

Tracking

unspecified
Thunderbird 7.0
x86_64
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

7 years ago
Created attachment 537350 [details]
Screenshot for About dialog

Firefox about dialog has close button now by bug 608934.
I think Thunderbird about dialog should have close button too.
(Assignee)

Updated

7 years ago
Summary: About window needs a close button → Port |Bug 608934 - About window needs a close button| to comm-central
(Assignee)

Comment 1

7 years ago
Created attachment 537435 [details] [diff] [review]
Port bug 608934 to Thunderbird

Please try this for Thunderbird.
(Assignee)

Comment 2

7 years ago
Created attachment 537436 [details] [diff] [review]
Port 608934 to calendar

I suppose the same fix is required for calendar.
Comment on attachment 537435 [details] [diff] [review]
Port bug 608934 to Thunderbird

It looks like I've seen this code already - but can't find the checking.
Attachment #537435 - Flags: review?(mbanner)
(In reply to comment #3)
> Comment on attachment 537435 [details] [diff] [review] [review]
> Port bug 608934 to Thunderbird
> 
> It looks like I've seen this code already - but can't find the checking.

Can you raise a bug in Calendar for that and request review to :fallen , thanks.
My previous reply was for comment 2 not comment 3 :(
(Assignee)

Comment 6

7 years ago
(In reply to comment #4)
> Can you raise a bug in Calendar for that and request review to :fallen ,
> thanks.

File bug 662244 for comment 2.
(Assignee)

Updated

7 years ago
Attachment #537436 - Attachment is obsolete: true
(Assignee)

Updated

7 years ago
Assignee: nobody → t.matsuu
Comment on attachment 537435 [details] [diff] [review]
Port bug 608934 to Thunderbird

Thanks for the patch.
Attachment #537435 - Flags: review?(mbanner) → review+
Takanori do you have checkin rights ?
(Assignee)

Comment 9

7 years ago
No.

I've set checkin-needed.
Keywords: checkin-needed
(Assignee)

Updated

7 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 10

7 years ago
Is there any action required for checkin-needed?
(In reply to comment #10)
> Is there any action required for checkin-needed?

no it will come on time.
Checked in: http://hg.mozilla.org/comm-central/rev/a264f7b23016
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 7.0
You need to log in before you can comment on or make changes to this bug.