662073 - Fix minor Server-Sent Events issues

Status: RESOLVED WONTFIX

(Core :: DOM: Core & HTML, defect)

Description

[Wellington Fernando de Macedo]

Attachment: test results

Opera has tests which fail in our implementation. The attachment compares the results of those tests when running them on Opera, Chrome and our implementation.

Comment 1

[Wellington Fernando de Macedo]

Attachment: patch v1

Comment 2

[Wellington Fernando de Macedo]

Attachment: test results

Only request-status-error.htm is failing. However I think our implementation is correct.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Could you perhaps attach the test results in some other form?

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 546326 [details] [diff] [review]
patch v1

>diff --git a/content/base/src/nsEventSource.cpp b/content/base/src/nsEventSource.cpp
>--- a/content/base/src/nsEventSource.cpp
>+++ b/content/base/src/nsEventSource.cpp
>@@ -475,16 +475,25 @@ nsEventSource::StreamReaderFunc(nsIInput
> 
>   PRInt32 srcCount, outCount;
>   PRUnichar out[2];
>   nsresult rv;
> 
>   const char *p = aFromRawSegment,
>              *end = aFromRawSegment + aCount;
> 
>+  // If we have more than one BOM char at the begin of the stream then
beginning of...
>+  // the converter will leave only one. So we handle the first BOM here instead
>+  // of inside nsEventSource::ParseCharacter(). See bug 662073.
>+  if (thisObject->mStatus == PARSE_STATE_BEGIN_OF_STREAM && aCount >= 2 &&
>+      static_cast<PRUnichar>(*p) == BOM_CHAR) {
>+    thisObject->mStatus = PARSE_STATE_BOM_WAS_READ;  // ignore it
>+    p += 2;
>+  }
>+

r=me if you add tests.

Comment 5

[Wellington Fernando de Macedo]

> r=me if you add tests.
Perhaps I could rewrite the Opera tests to Mochitest. Do you still have the url address of the Opera's php test sources?

Comment 6

[Wellington Fernando de Macedo]

Also, because I'm not an expert on laws, do we have license to rewrite the tests?

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

http://tc.labs.opera.com/apis/EventSource/
http://tc.labs.opera.com/apis/EventSource/resources/

I'll ask about the license of those tests.

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

Anne said it is ok to reuse the tests. No need to add any license text.

Comment 9

[Wellington Fernando de Macedo]

Attachment: test results

Comment 10

[Wellington Fernando de Macedo]

> Anne said it is ok to reuse the tests. No need to add any license text.
Please, ask them to add some written text in the sources that explicitly states which license the sources are under.

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

asking...

Comment 12

[Wellington Fernando de Macedo]

Duplicated of bugs 869432, 869865, 869874, 869875, 869878 and 869882.