Last Comment Bug 662082 - TI+JM: some AWFY graphs have a gray background
: TI+JM: some AWFY graphs have a gray background
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: All All
: -- normal (vote)
: ---
Assigned To: general
:
:
Mentors:
http://arewefastyet.com/?a=b&view=bre...
Depends on:
Blocks: 619433
  Show dependency treegraph
 
Reported: 2011-06-04 13:13 PDT by Jan de Mooij [:jandem]
Modified: 2011-06-16 06:43 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Screenshot (67.77 KB, image/png)
2011-06-04 13:18 PDT, Jan de Mooij [:jandem]
no flags Details

Description Jan de Mooij [:jandem] 2011-06-04 13:13:49 PDT
Some graphs (eg. v8-crypto) on the AWFY breakdown page (http://arewefastyet.com/?a=b&view=breakdown) have a gray background. I can only reproduce this with both TI and JM enabled (default prefs).

I can reproduce with a tinderbox build of revision 53649a1d6e45 on OS X, but I remember seeing it before.
Comment 1 Jan de Mooij [:jandem] 2011-06-04 13:18:22 PDT
Created attachment 537377 [details]
Screenshot
Comment 2 Brian Hackett (:bhackett) 2011-06-16 06:43:20 PDT
Did not get a reduction for this, but Jan downloaded the site and identified the place where we were breaking, and with spew output it was not hard to see the problem.  Plain IFEQ and IFNE opcodes did not call fixDoubleTypes before branching, so integers were not being coerced to doubles when branching to a point in the script with associated phi nodes.

http://hg.mozilla.org/projects/jaegermonkey/rev/9ff00d53b5a5

Note You need to log in before you can comment on or make changes to this bug.