662087 - Adding attachments via the command-line doesn't record their size

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect)

Description

[Jim Porter (:squib)]

Attachment: Fix this

From bug 661993 comment 1:
> Jim, the other day I tried to start thunderbird from the terminal:
> 
> thunderbird -compose "attachment='/home/jonathan/whatever.txt'"
> 
> and then the file size for the attachment wasn't shown. You might want to
> fix this case as well... :-)

Attached is a patch for this, but no tests, since I'm not sure how to test command-line arguments, or if that's even possible. Ideas?

Comment 1

[Jonathan Protzenko [:protz]]

Comment on attachment 537381 [details] [diff] [review]
Fix this

Review of attachment 537381 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the good patch, as usual. The cleanup in this section is very welcome, and I'm glad you scoped things properly and moved variables into let-bindings scoped to the then-block or the else-block; it improves the readability by a considerable factor. I've actually given this a try, and so far, it seems to work fine.

Comment 2

[Jonathan Protzenko [:protz]]

https://bugzilla.mozilla.org/show_bug.cgi?id=540330 is for testing command-line arguments

Comment 3

[Jim Porter (:squib)]

Checked in: http://hg.mozilla.org/comm-central/rev/52f3f5815bec