Closed Bug 662087 Opened 11 years ago Closed 10 years ago

Adding attachments via the command-line doesn't record their size

Categories

(Thunderbird :: OS Integration, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 7.0

People

(Reporter: squib, Assigned: squib)

References

Details

Attachments

(1 file)

Attached patch Fix thisSplinter Review
From bug 661993 comment 1:
> Jim, the other day I tried to start thunderbird from the terminal:
> 
> thunderbird -compose "attachment='/home/jonathan/whatever.txt'"
> 
> and then the file size for the attachment wasn't shown. You might want to
> fix this case as well... :-)

Attached is a patch for this, but no tests, since I'm not sure how to test command-line arguments, or if that's even possible. Ideas?
Attachment #537381 - Flags: review?(jonathan.protzenko)
Assignee: nobody → squibblyflabbetydoo
Blocks: 195702
Status: NEW → ASSIGNED
Comment on attachment 537381 [details] [diff] [review]
Fix this

Review of attachment 537381 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the good patch, as usual. The cleanup in this section is very welcome, and I'm glad you scoped things properly and moved variables into let-bindings scoped to the then-block or the else-block; it improves the readability by a considerable factor. I've actually given this a try, and so far, it seems to work fine.
Attachment #537381 - Flags: review?(jonathan.protzenko) → review+
Checked in: http://hg.mozilla.org/comm-central/rev/52f3f5815bec
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 7.0
Blocks: 662698
Blocks: 663193
You need to log in before you can comment on or make changes to this bug.