Adding attachments via the command-line doesn't record their size

RESOLVED FIXED in Thunderbird 7.0

Status

Thunderbird
OS Integration
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: squib, Assigned: squib)

Tracking

unspecified
Thunderbird 7.0
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 years ago
Created attachment 537381 [details] [diff] [review]
Fix this

From bug 661993 comment 1:
> Jim, the other day I tried to start thunderbird from the terminal:
> 
> thunderbird -compose "attachment='/home/jonathan/whatever.txt'"
> 
> and then the file size for the attachment wasn't shown. You might want to
> fix this case as well... :-)

Attached is a patch for this, but no tests, since I'm not sure how to test command-line arguments, or if that's even possible. Ideas?
Attachment #537381 - Flags: review?(jonathan.protzenko)
(Assignee)

Updated

7 years ago
Assignee: nobody → squibblyflabbetydoo
Blocks: 195702
Status: NEW → ASSIGNED
Comment on attachment 537381 [details] [diff] [review]
Fix this

Review of attachment 537381 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for the good patch, as usual. The cleanup in this section is very welcome, and I'm glad you scoped things properly and moved variables into let-bindings scoped to the then-block or the else-block; it improves the readability by a considerable factor. I've actually given this a try, and so far, it seems to work fine.
Attachment #537381 - Flags: review?(jonathan.protzenko) → review+
https://bugzilla.mozilla.org/show_bug.cgi?id=540330 is for testing command-line arguments
(Assignee)

Comment 3

7 years ago
Checked in: http://hg.mozilla.org/comm-central/rev/52f3f5815bec
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 7.0

Updated

7 years ago
Blocks: 662698

Updated

7 years ago
Blocks: 663193
You need to log in before you can comment on or make changes to this bug.