Last Comment Bug 662126 - Audit ConfirmEx callers to ensure that aCheckState is not an uninitialized PRBool
: Audit ConfirmEx callers to ensure that aCheckState is not an uninitialized PR...
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: General (show other bugs)
: unspecified
: x86 Windows 7
: -- normal (vote)
: mozilla7
Assigned To: Jonathan Protzenko [:protz]
:
Mentors:
Depends on: 662125
Blocks: 658351
  Show dependency treegraph
 
Reported: 2011-06-04 22:36 PDT by Kyle Huey [:khuey] (khuey@mozilla.com)
Modified: 2013-12-27 14:30 PST (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---
affected


Attachments
Fix all four call sites that I've found (2.51 KB, patch)
2011-06-06 12:27 PDT, Jonathan Protzenko [:protz]
bzbarsky: review+
Details | Diff | Splinter Review

Description Kyle Huey [:khuey] (khuey@mozilla.com) 2011-06-04 22:36:46 PDT
After hitting Bug 662125 in a debug build and finding the cause I found, without looking particularly hard,

http://hg.mozilla.org/mozilla-central/annotate/57bedceef898/netwerk/protocol/http/nsHttpChannelAuthProvider.cpp#l1185
http://hg.mozilla.org/mozilla-central/annotate/57bedceef898/security/manager/ssl/src/nsCrypto.cpp#l2940

There may be others as well.
Comment 1 Kyle Huey [:khuey] (khuey@mozilla.com) 2011-06-04 22:41:03 PDT
Looking at the patch for Bug 495618 would probably be a decent place to start.
Comment 3 Jonathan Protzenko [:protz] 2011-06-06 12:27:53 PDT
Created attachment 537608 [details] [diff] [review]
Fix all four call sites that I've found

This is all I could come up with. I've checked every instance of ConfirmEx in C++ code, and for each function that ends up calling ConfirmEx with the penultimate parameter being one of its own parameters, I've checked that function's own call sites.
Comment 4 Boris Zbarsky [:bz] 2011-06-06 12:46:25 PDT
Comment on attachment 537608 [details] [diff] [review]
Fix all four call sites that I've found

Looks good, thanks!
Comment 5 Jonathan Protzenko [:protz] 2011-06-07 11:08:24 PDT
http://hg.mozilla.org/mozilla-central/rev/8b3b1f9c132e

Note You need to log in before you can comment on or make changes to this bug.