Closed Bug 662126 Opened 10 years ago Closed 10 years ago

Audit ConfirmEx callers to ensure that aCheckState is not an uninitialized PRBool

Categories

(Core :: General, defect)

x86
Windows 7
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla7
Tracking Status
firefox7 --- affected

People

(Reporter: khuey, Assigned: protz)

References

Details

Attachments

(1 file)

Depends on: 662125
No longer depends on: 622125
Looking at the patch for Bug 495618 would probably be a decent place to start.
Assignee: nobody → jonathan.protzenko
This is all I could come up with. I've checked every instance of ConfirmEx in C++ code, and for each function that ends up calling ConfirmEx with the penultimate parameter being one of its own parameters, I've checked that function's own call sites.
Attachment #537608 - Flags: review?(bzbarsky)
Status: NEW → ASSIGNED
Comment on attachment 537608 [details] [diff] [review]
Fix all four call sites that I've found

Looks good, thanks!
Attachment #537608 - Flags: review?(bzbarsky) → review+
http://hg.mozilla.org/mozilla-central/rev/8b3b1f9c132e
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
You need to log in before you can comment on or make changes to this bug.