Last Comment Bug 662155 - addTab should report the exception when loadURIWithFlags fails
: addTab should report the exception when loadURIWithFlags fails
Product: Firefox
Classification: Client Software
Component: Tabbed Browser (show other bugs)
: Trunk
: All All
-- normal (vote)
: Firefox 7
Assigned To: Dão Gottwald [:dao]
: Dão Gottwald [:dao]
Depends on:
  Show dependency treegraph
Reported: 2011-06-05 07:48 PDT by Dão Gottwald [:dao]
Modified: 2011-06-10 05:40 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

patch (1021 bytes, patch)
2011-06-05 07:48 PDT, Dão Gottwald [:dao] review+
Details | Diff | Splinter Review

Description User image Dão Gottwald [:dao] 2011-06-05 07:48:28 PDT
Created attachment 537456 [details] [diff] [review]

See bug 662152 comment 2. A simplified testcase would be:
gBrowser.addTab("", 0)
Comment 1 User image Dão Gottwald [:dao] 2011-06-05 10:38:44 PDT
Comment 2 User image Vlad [QA] 2011-06-10 04:14:55 PDT
Can you please be more specific on how to verify this bug as being resolved fixed?
Comment 3 User image Dão Gottwald [:dao] 2011-06-10 04:45:10 PDT
Open the error console and execute this:

top.opener.gBrowser.addTab("", 0)

You should get an exception telling you that 0 is an invalid argument.
Comment 4 User image Vlad [QA] 2011-06-10 05:10:36 PDT
Is this the exception mentioned?

Error: [Exception... "Could not convert JavaScript argument - 0 was passed, expected object. Did you mean null? arg 2 [nsIWebNavigation.loadURI]"  nsresult: "0x80570035 (NS_ERROR_XPC_BAD_CONVERT_JS_ZERO_ISNOT_NULL)"  location: "JS frame :: chrome://global/content/bindings/browser.xml :: loadURIWithFlags :: line 193"  data: no]
Source File: chrome://browser/content/tabbrowser.xml
Line: 1334
Comment 5 User image Dão Gottwald [:dao] 2011-06-10 05:14:31 PDT
Comment 6 User image Vlad [QA] 2011-06-10 05:40:42 PDT
Considering comment4 and comment5, setting resolution to Verified Fixed.

Note You need to log in before you can comment on or make changes to this bug.