The default bug view has changed. See this FAQ.

addTab should report the exception when loadURIWithFlags fails

VERIFIED FIXED in Firefox 7

Status

()

Firefox
Tabbed Browser
VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

Trunk
Firefox 7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

6 years ago
Created attachment 537456 [details] [diff] [review]
patch

See bug 662152 comment 2. A simplified testcase would be:
gBrowser.addTab("http://bing.com", 0)
Attachment #537456 - Flags: review?(gavin.sharp)
Attachment #537456 - Flags: review?(gavin.sharp) → review+
(Assignee)

Comment 1

6 years ago
http://hg.mozilla.org/mozilla-central/rev/93911949517c
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 7

Comment 2

6 years ago
Can you please be more specific on how to verify this bug as being resolved fixed?
thx
(Assignee)

Comment 3

6 years ago
Open the error console and execute this:

top.opener.gBrowser.addTab("http://bing.com", 0)

You should get an exception telling you that 0 is an invalid argument.

Comment 4

6 years ago
Is this the exception mentioned?

Error: [Exception... "Could not convert JavaScript argument - 0 was passed, expected object. Did you mean null? arg 2 [nsIWebNavigation.loadURI]"  nsresult: "0x80570035 (NS_ERROR_XPC_BAD_CONVERT_JS_ZERO_ISNOT_NULL)"  location: "JS frame :: chrome://global/content/bindings/browser.xml :: loadURIWithFlags :: line 193"  data: no]
Source File: chrome://browser/content/tabbrowser.xml
Line: 1334
(Assignee)

Comment 5

6 years ago
yes...

Comment 6

6 years ago
Considering comment4 and comment5, setting resolution to Verified Fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.