Last Comment Bug 662155 - addTab should report the exception when loadURIWithFlags fails
: addTab should report the exception when loadURIWithFlags fails
Status: VERIFIED FIXED
:
Product: Firefox
Classification: Client Software
Component: Tabbed Browser (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 7
Assigned To: Dão Gottwald [:dao]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-05 07:48 PDT by Dão Gottwald [:dao]
Modified: 2011-06-10 05:40 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1021 bytes, patch)
2011-06-05 07:48 PDT, Dão Gottwald [:dao]
gavin.sharp: review+
Details | Diff | Review

Description Dão Gottwald [:dao] 2011-06-05 07:48:28 PDT
Created attachment 537456 [details] [diff] [review]
patch

See bug 662152 comment 2. A simplified testcase would be:
gBrowser.addTab("http://bing.com", 0)
Comment 1 Dão Gottwald [:dao] 2011-06-05 10:38:44 PDT
http://hg.mozilla.org/mozilla-central/rev/93911949517c
Comment 2 Vlad [QA] 2011-06-10 04:14:55 PDT
Can you please be more specific on how to verify this bug as being resolved fixed?
thx
Comment 3 Dão Gottwald [:dao] 2011-06-10 04:45:10 PDT
Open the error console and execute this:

top.opener.gBrowser.addTab("http://bing.com", 0)

You should get an exception telling you that 0 is an invalid argument.
Comment 4 Vlad [QA] 2011-06-10 05:10:36 PDT
Is this the exception mentioned?

Error: [Exception... "Could not convert JavaScript argument - 0 was passed, expected object. Did you mean null? arg 2 [nsIWebNavigation.loadURI]"  nsresult: "0x80570035 (NS_ERROR_XPC_BAD_CONVERT_JS_ZERO_ISNOT_NULL)"  location: "JS frame :: chrome://global/content/bindings/browser.xml :: loadURIWithFlags :: line 193"  data: no]
Source File: chrome://browser/content/tabbrowser.xml
Line: 1334
Comment 5 Dão Gottwald [:dao] 2011-06-10 05:14:31 PDT
yes...
Comment 6 Vlad [QA] 2011-06-10 05:40:42 PDT
Considering comment4 and comment5, setting resolution to Verified Fixed.

Note You need to log in before you can comment on or make changes to this bug.