47 bytes, text/x-phabricator-request
|Details | Review|
Recently I reviewed a patch which added some: [noscript, notxpcom] readonly attribute TimeStamp foo; where TimeStamp is a mozilla::TimeStamp but the C++ generated header had a function with an out param instead of just returning a TimeStamp... It would be really nice if we could use a return value here somehow.
The "normal" way to do this is: [noscript, notxpcom] TimeStamp getFood();
Right; I'm just asking for this to Just Work the other way instead of having to have weird-looking IDL...
At this point using [notxpcom] on an attribute gives an error at IDL-processing time. I'm just going to fix this, so people don't have to figure out the hard way that they need a method (or two, if not readonly) instead of an attribute.
Assignee: nobody → bzbarsky
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/5beaad8a185b Add support for [notxpcom] annotations on xpidl attributes. r=nika
Backed out for linting failure Push with failure: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=5beaad8a185bf4d01dd729d53e31429c8cdebf27 Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=211882933&repo=autoland&lineNumber=293 Backout: https://hg.mozilla.org/integration/autoland/rev/479f5e79077c06df25227e8628c29191c1e91ae6
Correct backout link: https://hg.mozilla.org/integration/autoland/rev/5a4abcac5a0beffbc3f7705332afd1696d154db0
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/95393acee0ea Add support for [notxpcom] annotations on xpidl attributes. r=nika
You need to log in before you can comment on or make changes to this bug.