662355 - Component returned failure code 0x80004005 (NS_ERROR_FAILURE) @ [extensions.xml::toggleOptions]

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Build Identifier: Mozilla/5.0 (Android; Linux armv7l; rv:7.0a1) Gecko/20110606 Firefox/7.0a1 Fennec/7.0a1

uncaught exception: [Exception... "Component returned failure code: 0x80004005 (NS_ERROR_FAILURE)"  nsresult: "0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame :: chrome://browser/content/bindings/extensions.xml :: toggleOptions :: line 116"  data: no]

STR:

1. Preferences, Add-ons pane
2. Scroll down, and install the recently risen to 'Recommended', Twitter Address Bar Search add-on.
3. After installation, tap Options

Comment 1

[Ed Lee :Mardak]

I'll assume

            let optionsURL = this.getAttribute("optionsURL");

is getting "", so, the following is failing:

            xhr.open("GET", optionsURL, false);
            xhr.send();

Comment 2

[Cristian Nicolae (:xti)]

I've noticed this error after I've installed Nightly Tester Tools for Mobile and Personas add-ons. It seems that Option button is not working.

Build id : Mozilla/5.0 (Android;Linux armv7l;rv:7.0a1)Gecko/201100606
Firefox/7.0a1 Fennec/7.0a1
Device: Motorola Droid 2
OS: Android 2.2

Comment 3

[Martijn Wargers (dead)]

This happens when the extensions url can't be found.

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

(In reply to comment #1)
> I'll assume
> 
>             let optionsURL = this.getAttribute("optionsURL");
> 
> is getting "", so, the following is failing:
> 
>             xhr.open("GET", optionsURL, false);
>             xhr.send();

We should be disabling the Options button in tht case:
http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/content/bindings/extensions.xml#56

Comment 5

[Ed Lee :Mardak]

The options button is disabled in 4.0.1 but not 7.0a1

Comment 6

[Ed Lee :Mardak]

(In reply to comment #4)
> We should be disabling the Options button in tht case:
> http://mxr.mozilla.org/mozilla-central/source/mobile/chrome/content/bindings/
> extensions.xml#56
It's getting the string "undefined" (not undefined).

Comment 7

[Ed Lee :Mardak]

http://hg.mozilla.org/mozilla-central/rev/b8f518466e04#l2.85
    2.85 -        listitem.setAttribute("optionsURL", addon.optionsURL ? addon.optionsURL : "");

http://hg.mozilla.org/mozilla-central/rev/b8f518466e04#l2.38
    2.38 +    listitem.setAttribute("optionsURL", aAddon.optionsURL);

Comment 8

[Ed Lee :Mardak]

Attachment: v1

Comment 9

[Daniel Holbert [:dholbert]]

http://hg.mozilla.org/projects/cedar/rev/908c1f8dd2ca

Comment 10

[Ed Lee :Mardak]

Doh! I forgot to [r=mfinkle]

How does the new landing process work with cedar, etc?

Comment 11

[Daniel Holbert [:dholbert]]

(In reply to comment #10)
> Doh! I forgot to [r=mfinkle]

Yup, I noticed & added that.

> How does the new landing process work with cedar, etc?

Cedar is just a grab-bag repo (largely for minimal and/or checkin-needed patches), which is periodically merged to m-c (every few days).

(If you need this to be merged to m-c sooner, I think anyone's basically free to do a cedar merge whenever they want.)

Comment 12

[(no longer active)]

http://hg.mozilla.org/mozilla-central/rev/908c1f8dd2ca

(In reply to comment #10)
> How does the new landing process work with cedar, etc?

cedar is now replaced with mozilla-inbound, please see the thread on dev.planning announcing the change.

Comment 13

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

Verified

Mozilla/5.0 (Android; Linux armv71; rv7.0a1) Gecko/20110613 Firefox/7.0a1 Fennec/7.0a1
Device: Thunderbolt
OS: Android 2.2