662362 - Don't use -mno-cygwin on mingw compilation (NSS part)

Status: RESOLVED FIXED

(NSS :: Build, defect, P2)

Description

[Jacek Caban]

Attachment: fix v1.0

This is follow-up bug for bug 647820.

Comment 1

[Wan-Teh Chang]

Comment on attachment 537617 [details] [diff] [review]
fix v1.0

r=wtc.

Comment 2

[Jacek Caban]

Thanks for the quick review!

Comment 3

[Daniel Holbert [:dholbert]]

This has been checkin-needed-for-NSS for 2 months.

kaie, maybe you could check this in (or suggest someone who could)?

Comment 4

[Daniel Holbert [:dholbert]]

(Actually maybe I'm wrong about this being NSS?  When I added the "[checkin-needed for NSS repo]" whiteboard status, I was assuming that it being in /security & getting r=wtc meant it was for NSS & not directly for mozilla-central.  But maybe this should land on mozilla-central after all?)

Comment 5

[Ed Morley [:emorley]]

From when I asked Brian Smith a while ago (I'm sure he won't mind me reproducing this here):

"More generally, no Mozilla patches should touch files in directories under security/ except for directories under security/manager. All the other directories (coreconf, dbm, nss) are managed in a separate repository..."

So as far as I understand it, this still needs to land on NSS.

Comment 6

[Jacek Caban]

HG history of the touched patch has (almost) only imports of NSS snapshots.

Comment 7

[Ed Morley [:emorley]]

wtc/kaie, bump - this has been checkin-needed for 3 months, cluttering up the checkin-needed saved search that everyone uses, please can it be dealt with...

Comment 8

[Wan-Teh Chang]

Patch checked in on the NSS trunk (NSS 3.13).

Checking in WIN32.mk;
/cvsroot/mozilla/security/coreconf/WIN32.mk,v  <--  WIN32.mk
new revision: 1.44; previous revision: 1.43
done