662698 - Port |Bug 662087 - Adding attachments via the command-line doesn't record their size| to SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: MailNews: Composition, defect)

Description

[Ian Neal]

Attachment: Size cmdline attachments

When adding attachments from the command-line the file size for the attachment isn't show.

This ports the TB fix.

Comment 1

[[e-mail]]

Comment on attachment 537923 [details] [diff] [review]
Size cmdline attachments

This fails if the passed-in path is invalid or is not a file. (Previously the compose window would open with an invalid attachment and you would find out later when you tried to save or send the message.) Since this is the command line we need to be able to cope with potentially dodgy data.

Comment 2

[Ian Neal]

Attachment: Size cmdline attachments using resolveURI

Changes since last version:
* Uses commandLine's resolveURI functionality to process attachment list.
* Adds new error message for when file specified in attachment is missing.
* Encodes web uris so non-ascii ones get passed correctly - sending of non-ascii web pages doesn't work but that is bug 663183 and was already present.
* Ports TB Bug 549580 - If compose window initialisation fails, don't hide the error by throwing it to the text console

Comment 3

[Ian Neal]

Attachment: With resolveURI but no double encoding

Changes since last version:
* Removed the double encoding of web page urls.

Comment 4

[[e-mail]]

Comment on attachment 538632 [details] [diff] [review]
With resolveURI but no double encoding

>+        var commandLine = Components.classes["@mozilla.org/toolkit/command-line;1"]
>+                                    .createInstance();
Heh, I had no idea that this component was readily available.

>+          if (uri.scheme == "file")
>+          {
>+            let localFile = fileHandler.getFileFromURLSpec(uri.spec);
I think you can write this as
if (uri instanceof Components.interface.nsIFileURL)
{
  if (uri.file.exists())
etc.

Comment 5

[Ian Neal]

Attachment: Using resolveURI and nsIFileURL [Checked in: Comment 6]

Comment 6

[Ian Neal]

Comment on attachment 538773 [details] [diff] [review]
Using resolveURI and nsIFileURL [Checked in: Comment 6]

http://hg.mozilla.org/comm-central/rev/804b99311f80