662747 - Move Ready For L10n checkbox to Approve dialog

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P1)

Description

[Erik Rose [:erik][:erikrose]]

At the moment, on my ready-for-l10n integration branch, the Ready for Localization checkbox is at the bottom of the revision edit form. After talking with Michael today, some changes are needed.

Instead of appearing at the bottom of the rev form, the checkbox should be part of the approve dialog, somewhere under the significance radio buttons. Further, it should be protected with a new permission. Users who don't have the permission may still be able to approve the article, but the Ready bit will remain false. (Later, a privileged user can come along and create a new revision whose only difference is a flipped Ready bit; this should be an odd case.) The checkbox should be off by default, because sending all those notifications to localizers is a big deal.

If somebody wants to help out with this, I will gladly accept. :-) I promise not to squash anything on the ready-for-l10n branch until it lands.

Comment 1

[Erik Rose [:erik][:erikrose]]

Landed on master: http://github.com/jsocol/kitsune/commit/24404f22d76972297f9e3d

Comment 2

[Rebecca Billings [:rbillings]]

I created a translation version of a document. I edited the US doc, and when I approved it, I checked the localization checkbox with it being a minor change. I was expecting it to display here:
https://support.allizom.org/ar/localization/needing-updates

article:
https://support.allizom.org/en-US/kb/albatross/history

Please add a comment if the expected results are incorrect.

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to comment #2)
I am not sure how /localization/needing-updates works or is supposed to work, but the checkbox that this bug is about works since revision information for your new revision is showing "Ready for localization: Yes". Maybe there is a bug in the needing-updates page?

Comment 4

[James Socol [:jsocol, :james]]

Isn't this fixed on master but not yet on support-release because it's waiting for the rest of the ready-for-l10n branch to land?

Comment 5

[Kadir Topal [:atopal]]

Rebecca, you have to mark your change as a major one for it to show up on the dashboard. The minor edit is just for spelling mistakes etc. and is therefore not shown to localizers. I created a major change for that article and it did show up on the dashboard. So I'm closing this one.

Comment 6

[Rebecca Billings [:rbillings]]

Verified on support.allizom that new article is listed on localization as needing translation only after checkbox has been selected.