662794 - Attaching screenshot doesn't work

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[Chris AtLee [:catlee]]

I'm trying to attach a screenshot to my addon, and not having much luck.

I click on "Add a Screenshot" button, select a file, and then nothing happens. I get this in the error log:

Error: m.getAsDataURL is not a function
Source File: https://static-cdn.addons.mozilla.net/media/js/zamboni/devhub-min.js?build=29c4afd
Line: 1

Tried with both firefox nightly build and chrome.

Comment 1

[Andreas Wagner [:TheOne] [use NI]]

works for me with Firefox 4.0.1

Comment 2

[Wil Clouser [:clouserw]]

Same.  Works for me in a nightly from a couple days ago.  Chris, what is your UA?

Comment 3

[Chris AtLee [:catlee]]

Mozilla/5.0 (X11; Linux x86_64; rv:7.0a1) Gecko/20110607 Firefox/7.0a1

built from http://hg.mozilla.org/mozilla-central/rev/9014863a7e2a

Comment 4

[Wil Clouser [:clouserw]]

I updated to today's nightly and can reproduce.  Not sure if it's a bug in the nightly or a purposeful change.

Comment 5

[Andy McKay]

https://developer.mozilla.org/en/DOM/file#getAsDataURL%28%29 was deprecated in Firefox 3.6. Perhaps we should move to the file api anyway http://hacks.mozilla.org/category/firefox-36/as/complete/page/2/

Comment 6

[Gregory Koberger (:gkoberger)]

This works for me, however andy's right-- we should switch anyway.

Can anyone still reproduce?

Comment 7

[Gregory Koberger (:gkoberger)]

I still had no luck reproducing this anywhere (3.6, 4, Beta/5, Aurora/6, Nightly/7 or Chrome), however I switched over to the new async FileAPI if it's available.  If not, it falls back to the synchronous FileAPI that we're currently using.

http://github.com/jbalogh/zamboni/commit/7d99e70

Comment 8

[krupa raj[:krupa]]

I can still reproduce this behavior on Chrome 12.0.742.100

Comment 9

[Gregory Koberger (:gkoberger)]

Krupa -- this bug works on Chrome 12; the bug you found has nothing to do with it.  However, I fixed it anyway, since I like you :)

https://github.com/jbalogh/zamboni/commit/c428bb8fa68355d5664dcef2014c2bf7b2e69633

Comment 10

[krupa raj[:krupa]]

Filed bug about screenshot weirdness (bug 666440)

Checked that uploading screenshot works in Chrome 12 and Firefox nightly. Thanks for fixing all the issues.