Closed Bug 662795 Opened 8 years ago Closed 8 years ago

Intermittent failure layout/base/crashtests/331883-1.html | load failed: timed out waiting for reftest-wait to be removed

Categories

(Core :: Layout, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla7

People

(Reporter: masayuki, Assigned: jdm)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

> REFTEST TEST-START | file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/base/crashtests/331883-1.html
> REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/base/crashtests/331883-1.html | load failed: timed out waiting for reftest-wait to be removed
> REFTEST INFO | Saved log: START file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/base/crashtests/331883-1.html
> REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering WaitForTestEnd
> REFTEST INFO | Saved log: [CONTENT] WaitForTestEnd: Adding listeners
> REFTEST INFO | Saved log: Initializing canvas snapshot
> REFTEST INFO | Saved log: [CONTENT] WaitForTestEnd: Adding listeners
> REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_TO_FIRE_INVALIDATE_EVENT
> REFTEST INFO | Saved log: [CONTENT] MakeProgress: dispatching MozReftestInvalidate
> REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_FOR_REFTEST_WAIT_REMOVAL
> REFTEST INFO | Saved log: [CONTENT] MakeProgress: waiting for reftest-wait to be removed
> REFTEST INFO | Saved log: [CONTENT] AfterPaintListener in file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/base/crashtests/331883-1.html
> REFTEST INFO | Saved log: Updating canvas for invalidation
> REFTEST INFO | Saved log: [CONTENT] AfterPaintListener in file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/base/crashtests/331883-1.html
> REFTEST INFO | Saved log: [CONTENT] AfterPaintListener in file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/base/crashtests/331883-1-inner.html
> REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_FOR_REFTEST_WAIT_REMOVAL
> REFTEST INFO | Saved log: [CONTENT] MakeProgress: waiting for reftest-wait to be removed
> REFTEST INFO | Saved log: [CONTENT] AfterPaintListener in file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/base/crashtests/331883-1.html
> REFTEST INFO | Saved log: Updating canvas for invalidation
> REFTEST INFO | Saved log: [CONTENT] AfterPaintListener in file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/base/crashtests/331883-1.html
> REFTEST INFO | Saved log: [CONTENT] AfterPaintListener in file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/base/crashtests/331883-1-inner.html
> REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_FOR_REFTEST_WAIT_REMOVAL
> REFTEST INFO | Saved log: [CONTENT] MakeProgress: waiting for reftest-wait to be removed
> REFTEST INFO | Saved log: [CONTENT] AfterPaintListener in file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/base/crashtests/331883-1.html
> REFTEST INFO | Saved log: Updating canvas for invalidation
> REFTEST INFO | Saved log: [CONTENT] AfterPaintListener in file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/base/crashtests/331883-1.html
> REFTEST INFO | Saved log: [CONTENT] AfterPaintListener in file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/base/crashtests/331883-1-inner.html
> REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_FOR_REFTEST_WAIT_REMOVAL
> REFTEST INFO | Saved log: [CONTENT] MakeProgress: waiting for reftest-wait to be removed
> REFTEST INFO | Saved log: [CONTENT] AfterPaintListener in file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/base/crashtests/331883-1.html
> REFTEST INFO | Saved log: Updating canvas for invalidation
> REFTEST INFO | Saved log: [CONTENT] AfterPaintListener in file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/base/crashtests/331883-1.html
> REFTEST INFO | Saved log: [CONTENT] AfterPaintListener in file:///Users/cltbld/talos-slave/test/build/reftest/tests/layout/base/crashtests/331883-1-inner.html
> REFTEST INFO | Saved log: [CONTENT] MakeProgress: STATE_WAITING_FOR_REFTEST_WAIT_REMOVAL
> REFTEST INFO | Saved log: [CONTENT] MakeProgress: waiting for reftest-wait to be removed
> REFTEST INFO | Saved log: [CONTENT] AttrModifiedListener fired
> REFTEST INFO | Loading a blank page

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307541710.1307542028.26520.gz#err0
Blocks: 438871
This test, and also <http://mxr.mozilla.org/mozilla-central/source/layout/base/crashtests/331883-2.html?force=1> uses a timeout of 1 second to wait for its inner frame to (hopefully) load five times, and is prone to race conditions.

It should be fairly simple to rewrite it to listen to the load event on the iframe 5 times instead of relying on this timeout magic.

Josh, is this something that you have cycles for?  :-)
For you, always!
Assignee: nobody → josh
Attachment #538367 - Flags: review?(roc)
Comment on attachment 538367 [details] [diff] [review]
Remove flaky timeout from 331883-1.html. Also remove identical test 331883-2.html.

Review of attachment 538367 [details] [diff] [review]:
-----------------------------------------------------------------
Attachment #538367 - Flags: review?(roc) → review+
Keywords: checkin-needed
Pushed to m-i.  Thanks!
Keywords: checkin-needed
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
I understand why the test had an internal race condition, which could cause the iframe to load 4 or 6 times instead of 5, but what caused the test as a whole to time out?
If I'm reading the logs correctly, the inner frame has been loaded 4 times, and then the DOM attr modified callback has gotten called but without effect.  Maybe dbaron knows why?
Maybe it's the same problem as bug 655495 / bug 623091.
I'm not really sure...
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.