At the moment, we have tests that expect JS_EvaluateUCInStackFrame to be able to extend call objects of arbitrary functions: js/src/jit-test/tests/jaeger/bug563000/eif-call-newvar.js js/src/jit-test/tests/jaeger/bug563000/eif-getter-newvar.js js/src/jit-test/tests/jaeger/bug563000/eif-trap-newvar.js Implementing this in all cases requires retaining enough information to undo all the def/use analysis the bytecode compiler does, possibly re-instating scope objects that don't exist any more on closures' scope chains, and so on. This is impractical. We should, however, verify that JS_EvaluateUCInStackFrame can extend the global and extensible call objects --- that is, in cases where the bytecode compiler has given up on binding analysis already.
Created attachment 538044 [details] [diff] [review] Don't require JS_EvaluateUCScriptInStackFrame to be able to extend call objects that the bytecode compiler didn't expect to be extensible.
Assignee: nobody → jimb
Attachment #538044 - Flags: review?(dvander)
Attachment #538044 - Flags: review?(dvander) → review+
Status: NEW → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.