Last Comment Bug 663041 - layout should use mozilla::Preferences
: layout should use mozilla::Preferences
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Layout (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla7
Assigned To: Masayuki Nakano [:masayuki] (Mozilla Japan)
:
Mentors:
Depends on: 656826
Blocks:
  Show dependency treegraph
 
Reported: 2011-06-08 23:27 PDT by Masayuki Nakano [:masayuki] (Mozilla Japan)
Modified: 2011-06-11 20:30 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch v1.0 (17.00 KB, patch)
2011-06-08 23:27 PDT, Masayuki Nakano [:masayuki] (Mozilla Japan)
roc: review+
Details | Diff | Splinter Review
Patch v1.1 (mq) (11.05 KB, patch)
2011-06-09 17:51 PDT, Masayuki Nakano [:masayuki] (Mozilla Japan)
no flags Details | Diff | Splinter Review

Description Masayuki Nakano [:masayuki] (Mozilla Japan) 2011-06-08 23:27:47 PDT
Created attachment 538187 [details] [diff] [review]
Patch v1.0
Comment 1 Robert O'Callahan (:roc) (Exited; email my personal email if necessary) 2011-06-09 03:29:12 PDT
Comment on attachment 538187 [details] [diff] [review]
Patch v1.0

Review of attachment 538187 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/tools/layout-debug/src/nsLayoutDebuggingTools.cpp
@@ +589,2 @@
>  
> +    nsCOMPtr<nsIPrefService> prefService = Preferences::GetService();

Doesn't need to be an nsCOMPtr.
Comment 2 Masayuki Nakano [:masayuki] (Mozilla Japan) 2011-06-09 17:51:12 PDT
Created attachment 538398 [details] [diff] [review]
Patch v1.1 (mq)
Comment 3 Masayuki Nakano [:masayuki] (Mozilla Japan) 2011-06-11 20:30:29 PDT
http://hg.mozilla.org/mozilla-central/rev/e37011790a8a

Note You need to log in before you can comment on or make changes to this bug.