663077 - Buildbot does not calculate build revision when only change hash is used to trigger a build

Status: VERIFIED FIXED

(Tamarin Graveyard :: Build Config, defect)

Description

[Brent Baker]

Attachment: Calculate change info bash on hash

If you request a sandbox build only using the change hash, buildbot will fail in the smoke phase when it tries to confirm the revision of the deployed avmshell on remote machines (linux-arm, android, linux-mips). The all/util-calculate-change.sh script currently does not handle only being passed the change hash.

Comment 1

[Brent Baker]

Comment on attachment 538232 [details] [diff] [review]
Calculate change info bash on hash

This is sort of naive since it assumes that anything passed in that has a length of 12 is a revision hash. This will start to fail once tamarin reaches change number 100,000,000,000, but we should be ok for a little while.

Comment 2

[James Sudduth]

Comment on attachment 538232 [details] [diff] [review]
Calculate change info bash on hash

Looks good - might want to fix the typo in the comment ('lenght').

Comment 3

[Tamarin Bot]

changeset: 6385:50081aa3683b
user:      Brent Baker <[e-mail]>
summary:   Bug 663077 - Buildbot does not calculate build revision when only change hash is used to trigger a build (r=jsudduth)

http://hg.mozilla.org/tamarin-redux/rev/50081aa3683b