Last Comment Bug 663172 - Build issues in latest ionmonkey change
: Build issues in latest ionmonkey change
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: unspecified
: x86 Mac OS X
-- normal (vote)
: ---
Assigned To: general
: Jason Orendorff [:jorendorff]
Depends on:
  Show dependency treegraph
Reported: 2011-06-09 11:25 PDT by Andrew Scheff
Modified: 2011-06-09 12:39 PDT (History)
1 user (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

tiny change (604 bytes, patch)
2011-06-09 11:25 PDT, Andrew Scheff
dvander: review+
Details | Diff | Splinter Review

Description User image Andrew Scheff 2011-06-09 11:25:07 PDT
Created attachment 538298 [details] [diff] [review]
tiny change

After pulling the latest changes (Bug 661736), I got errors when trying to build the shell.  Specifically:

/Users/Andy/ionmonkey/js/src/ion/IonLIR.h:339: error: invalid use of non-static data member ‘js::ion::LDefinition::bits_’
/Users/Andy/ionmonkey/js/src/ion/IonLIR.h:353: error: from this location
/Users/Andy/ionmonkey/js/src/ion/IonLIR.h:355: error: ‘js::ion::LDefinition::VREG_MASK’ cannot be initialized by a non-constant expression when being declared
/Users/Andy/ionmonkey/js/src/ion/IonLIR.h: In member function ‘void js::ion::LDefinition::set(uint32, js::ion::LDefinition::Type, js::ion::LDefinition::Policy)’:
/Users/Andy/ionmonkey/js/src/ion/IonLIR.h:391: error: parameter may not have variably modified type ‘int [(((long unsigned int)((((unsigned int)((1 << ((int)js::ion::LDefinition::VREG_BITS)) - 1)) > 2097150u) ? 0 : -0x00000000000000002)) + 1u)]’

I've fixed the issue (I think), diff attached
Comment 1 User image David Anderson [:dvander] 2011-06-09 12:10:18 PDT
Comment on attachment 538298 [details] [diff] [review]
tiny change

Whoops, thanks!

Note You need to log in before you can comment on or make changes to this bug.