e10s HTTP: initialize prnetaddrs correctly in child

RESOLVED FIXED in mozilla7

Status

()

Core
Networking: HTTP
RESOLVED FIXED
6 years ago
4 years ago

People

(Reporter: jduell, Assigned: jduell)

Tracking

unspecified
mozilla7
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Spin-off of bug 661158.  Just minor codefix to move some initializers that should now be in HttpBaseChannel, not nsHttpChannel.
(Assignee)

Comment 1

6 years ago
Created attachment 538347 [details] [diff] [review]
Approved patch copied from bug 661158

Copying jdm's +r.

Includes breakpoint to cause parent to crash (intentionally) if we see it trying to pass in a Unix domain socket enum over IPDL.
Attachment #538347 - Flags: review+
(Assignee)

Updated

6 years ago
Keywords: checkin-needed
(Assignee)

Comment 2

6 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/a19e5f55f67c
Keywords: checkin-needed
Whiteboard: [inbound
(Assignee)

Updated

6 years ago
Whiteboard: [inbound → [inbound]
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Whiteboard: [inbound]
Target Milestone: --- → mozilla7
http://hg.mozilla.org/mozilla-central/rev/a19e5f55f67c

Updated

6 years ago
Assignee: nobody → jduell.mcbugs

Comment 4

6 years ago
Comment on attachment 538347 [details] [diff] [review]
Approved patch copied from bug 661158

So, this patch does not actually fix the topcrash that is tracked by bug 661158. In fact, it arguably makes the crash strictly worse, since it changes a content process crash into a browser crash. On the other hand, this change should make us crash at the point when we start sending bad data over the wire, and this is good because Jason and I can't figure out why this would ever happen. Obviously it is, and it's happening fairly frequently, so this kind of data would be valuable to us.
Attachment #538347 - Flags: approval-mozilla-aurora?
(Assignee)

Comment 5

6 years ago
Comment on attachment 538347 [details] [diff] [review]
Approved patch copied from bug 661158

> this change should make us crash at the point when we start sending bad 
> data over the wire, and this is good 

+1

Comment 6

6 years ago
We didn't have a mobile rep at today's triage but desktop has no concerns here so I'm delegating the yes/no to which ever of the Mobile drivers gets here first.
Comment on attachment 538347 [details] [diff] [review]
Approved patch copied from bug 661158

since this doesn't actually fix anything I don't think we want to take this. If my understanding is incorrect, please explain and re-nom
Attachment #538347 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora-
You need to log in before you can comment on or make changes to this bug.