Should beta files be listed under Add-on History

VERIFIED FIXED in 6.1.2

Status

addons.mozilla.org Graveyard
Admin/Editor Tools
P2
normal
VERIFIED FIXED
7 years ago
2 years ago

People

(Reporter: krupa, Assigned: gkoberger)

Tracking

unspecified
6.1.2

Details

(Whiteboard: [ReviewTeam])

(Reporter)

Description

7 years ago
steps to reproduce:
1. Load https://addons.mozilla.org/en-US/editors/review/compact-menu-2?num=2
2. Notice that beta versions are also listed with 'This add-on version has not been reviewed' status.


observed behavior:
Some editors were mentioning that they'd like all add-on versions listed for the sake of completeness. Should this also include beta files?
(Reporter)

Updated

7 years ago
Component: Public Pages → Admin/Editor Tools
QA Contact: web-ui → admin-tools
(Reporter)

Comment 1

7 years ago
jorgev says that beta files should be left out.
Whiteboard: [ddn]
Yes, they should be left out.

More importantly, I ran into a related bug when reviewing this add-on:

https://addons.mozilla.org/en-US/editors/review/invisiblehand?num=3

It had a version pending review and a newer beta version as well. The review page showed the beta as the version being reviewed, and when I submitted the review it actually approved the beta version instead of the one pending review.

While this is rare, it should be taken into consideration.
Priority: -- → P2
Whiteboard: [required amo-editors]
Target Milestone: --- → 6.1.2
Assignee: nobody → gkoberger
(Assignee)

Comment 3

7 years ago
http://github.com/jbalogh/zamboni/commit/24adc31

Should fix both problems.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Reporter)

Comment 4

7 years ago
Newly submitted beta version is not listed in the editor reviews anymore. Verified at https://addons-next.allizom.org/en-US/editors/review/overlay-that-uses-the-inser?num=1

Older add-ons are not listing beta versions anymore. verified at https://addons-next.allizom.org/en-US/editors/review/compact-menu-2?num=2
Status: RESOLVED → VERIFIED
Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...
Whiteboard: [required amo-editors] → [ReviewTeam]
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.