663248 - Should beta files be listed under Add-on History

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P2)

Description

[krupa raj[:krupa]]

steps to reproduce:
1. Load https://addons.mozilla.org/en-US/editors/review/compact-menu-2?num=2
2. Notice that beta versions are also listed with 'This add-on version has not been reviewed' status.


observed behavior:
Some editors were mentioning that they'd like all add-on versions listed for the sake of completeness. Should this also include beta files?

Comment 1

[krupa raj[:krupa]]

jorgev says that beta files should be left out.

Comment 2

[Jorge Villalobos [:jorgev] (he/him)]

Yes, they should be left out.

More importantly, I ran into a related bug when reviewing this add-on:

https://addons.mozilla.org/en-US/editors/review/invisiblehand?num=3

It had a version pending review and a newer beta version as well. The review page showed the beta as the version being reviewed, and when I submitted the review it actually approved the beta version instead of the one pending review.

While this is rare, it should be taken into consideration.

Comment 3

[Gregory Koberger (:gkoberger)]

http://github.com/jbalogh/zamboni/commit/24adc31

Should fix both problems.

Comment 4

[krupa raj[:krupa]]

Newly submitted beta version is not listed in the editor reviews anymore. Verified at https://addons-next.allizom.org/en-US/editors/review/overlay-that-uses-the-inser?num=1

Older add-ons are not listing beta versions anymore. verified at https://addons-next.allizom.org/en-US/editors/review/compact-menu-2?num=2

Comment 5

[Jorge Villalobos [:jorgev] (he/him)]

Reclassifying editor bugs and changing to a new whiteboard flag. Spam, spam, spam, spam...