663309 - Messages about cancelled/restarted no longer automatically disappear

Status: RESOLVED FIXED

(Tree Management Graveyard :: TBPL, defect)

Description

[Cameron McCormack (:heycam)]

It used to be that the yellow status box at the top of the page would hide itself if none of the messages required explicit dismissal (e.g. errors) or were "Loading..."-type messages.  Now, it stays permanently.  That means if I cancel some builds it will stay until I reload the page.  If I cancel a few in a row, then the status box will grow tall and obscure useful parts of the page, at which point I have to reload to continue using the page.

Comment 1

[Mounir Lamouri (:mounir)]

I have the same issue but it actually happens only with the rebuild/cancel messages. Other ones are working correctly.

Thanks for opening that bug, I've been too lazy to do it before :)

Comment 2

[Markus Stange [:mstange]]

I broke this in bug 659705.

Comment 3

[Markus Stange [:mstange]]

Attachment: v1

I think when I broke this I was thinking that "loading" and "error" were the only used message types because I hadn't caught that some messages get an empty type when _makeStatusCallback is called without the type argument.
I've added a comment.

Comment 4

[Cameron McCormack (:heycam)]

Comment on attachment 538560 [details] [diff] [review]
v1

LGTM.  The use of `querySelector() != null` is better than the original `querySelectorAll().length != 0`, too.

Comment 5

[Markus Stange [:mstange]]

http://hg.mozilla.org/users/mstange_themasta.com/tinderboxpushlog/rev/6fc33585a314