addRetryEvaluateCommand shouldn't ignore timeout parameter

RESOLVED FIXED

Status

Release Engineering
General
RESOLVED FIXED
7 years ago
5 years ago

People

(Reporter: rail, Assigned: bhearsum)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 obsolete attachment)

Created attachment 538489 [details] [diff] [review]
addRetryEvaluateCommand timeout

addRetryEvaluateCommand wraps shell commands and run them using retry.py.

ATM, addRetryEvaluateCommand doesn't pass timeout parameter to retry.py, so it always uses its own default 300s.
Attachment #538489 - Flags: review?(bhearsum)
Worked fine in staging.
(Assignee)

Updated

7 years ago
Attachment #538489 - Flags: review?(bhearsum) → review+
(Assignee)

Comment 2

7 years ago
Comment on attachment 538489 [details] [diff] [review]
addRetryEvaluateCommand timeout

Landed this on default. I don't see any instances of this failing in production, so no need to rush through a reconfig for it.
Attachment #538489 - Flags: checked-in+

Comment 3

7 years ago
Comment on attachment 538489 [details] [diff] [review]
addRetryEvaluateCommand timeout

Backed out due to backing out bug 613953.
Attachment #538489 - Flags: checked-in+ → checked-in-
(Assignee)

Updated

7 years ago
Attachment #538489 - Attachment is obsolete: true
(Assignee)

Comment 4

7 years ago
fixed by the latest patch in bug 613953.
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.