Closed Bug 663378 Opened 13 years ago Closed 13 years ago

Intermittent failure in layout/style/test/test_acid3_test46.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - runTest is not defined at http://mochi.test:8888/tests/layout/style/test/test_acid3_test46.html:1

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Platform:
All
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla10

People

(Reporter: mounir, Assigned: philor)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Fix v.1
1.15 KB, patch
dbaron
: review+
Details | Diff | Splinter Review 
s: talos-r3-xp-058
4531 ERROR TEST-UNEXPECTED-FAIL | /tests/layout/style/test/test_acid3_test46.html | [SimpleTest/SimpleTest.js, window.onerror] An error occurred - runTest is not defined at http://mochi.test:8888/tests/layout/style/test/test_acid3_test46.html:1

http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1307703855.1307704936.8430.gz&fulltext=1
Attached patch Fix v.1 — — Splinter Review 
It puts the function definition before the onload that calls it, or it gets the failure again.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #568850 - Flags: review?(dbaron)
Comment on attachment 568850 [details] [diff] [review]
Fix v.1

This seems ok, but I don't think it's actually the problem.

I think the problem is that https://hg.mozilla.org/mozilla-central/rev/3f20f058583c did not add SimpleTest.waitForExplicitFinish() and SimpleTest.finish() calls, so much of the time the test doesn't test anything at all, but if the timing's just right, it manages to run things in the middle of unloading.
Attachment #568850 - Flags: review?(dbaron) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/5321cee08f41

I couldn't find any evidence of us either running no tests or only part of the tests, but my interest in loading full logs waned pretty quickly, so I just threw in the waitForExplicit/finish to be sure it wouldn't be a problem.
https://hg.mozilla.org/mozilla-central/rev/5321cee08f41
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla10
Whiteboard: [orange]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: