Closed
Bug 663401
Opened 11 years ago
Closed 11 years ago
browser_bug435788.js cleanup
Categories
(Toolkit Graveyard :: Plugin Finder Service, defect)
Toolkit Graveyard
Plugin Finder Service
Tracking
(Not tracked)
VERIFIED
FIXED
mozilla7
People
(Reporter: dao, Assigned: dao)
References
Details
Attachments
(1 file, 1 obsolete file)
27.14 KB,
patch
|
mossop
:
review+
|
Details | Diff | Splinter Review |
I'm trying to figure out why browser_bug435788.js leaks pluginInstallerWizard.xul 10 times. The longwindedness of the test doesn't help, so I'd like to consolidate this. When I pushed the attached patch to the tryserver, the number of leaked wizard windows went down 9, but it could be that that number just isn't stable.
Attachment #538526 -
Flags: review?(dtownsend)
Assignee | ||
Comment 1•11 years ago
|
||
> When I pushed the attached patch to the tryserver, the number of leaked
> wizard windows went down 9
It went down /to/ 9 (not "by", which would have been great).
Assignee | ||
Comment 2•11 years ago
|
||
I looked through a few more logs, the number of leaked windows is more or less random (varied between 7 and 12).
Assignee | ||
Comment 3•11 years ago
|
||
got rid of eval
Attachment #538526 -
Attachment is obsolete: true
Attachment #538526 -
Flags: review?(dtownsend)
Attachment #539158 -
Flags: review?(dtownsend)
Comment 4•11 years ago
|
||
Comment on attachment 539158 [details] [diff] [review] patch v2 Review of attachment 539158 [details] [diff] [review]: ----------------------------------------------------------------- Looks ok. I heard rumours that we are ditching the pfs code, if that is true then spending much time on this might be a waste of time. Dolske might know more.
Attachment #539158 -
Flags: review?(dtownsend) → review+
Assignee | ||
Comment 5•11 years ago
|
||
http://hg.mozilla.org/mozilla-central/rev/545e27bf8b81
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla7
Comment 6•11 years ago
|
||
Verified fixed based on results in http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1314796096.1314800048.10181.gz&fulltext=1
Status: RESOLVED → VERIFIED
Updated•8 years ago
|
Product: Toolkit → Toolkit Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•