Any page with a "test" button on it doesn't validate

VERIFIED FIXED in Builder 0.9.6

Status

--
minor
VERIFIED FIXED
7 years ago
4 years ago

People

(Reporter: rfreebern, Assigned: rfreebern)

Tracking

unspecified
Builder 0.9.6

Details

(URL)

(Assignee)

Description

7 years ago
The HTML generated for the add-on "Test" button includes a rel="jid..." attribute that is invalid. This affects the homepage, the search results page, the user dashboard, etc.

See http://html5.validator.nu/?doc=https%3A%2F%2Fbuilder-addons.allizom.org%2F for an example.

A suggested solution is to use a data-jetpackid attribute instead.
(Assignee)

Updated

7 years ago
Assignee: nobody → ryan
(Assignee)

Comment 2

7 years ago
Sean gave me some feedback and I found another affected file, which is covered by https://github.com/rfreebern/FlightDeck/commit/24f8c5cde152b54b323c89b8f59aca786a129d4c

All other instances of rel attributes in the code are unrelated to the test buttons.
(Assignee)

Comment 3

7 years ago
Fixed by https://github.com/mozilla/FlightDeck/commit/95d3d23e7fe8a03d0b7165274f17399d63c28282
Status: NEW → RESOLVED
Last Resolved: 7 years ago
Resolution: --- → FIXED
(Assignee)

Updated

7 years ago
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Updated

7 years ago
Status: REOPENED → RESOLVED
Last Resolved: 7 years ago7 years ago
Resolution: --- → FIXED
Verified FIXED: http://html5.validator.nu/?doc=https%3A%2F%2Fbuilder-addons.allizom.org%2F
Status: RESOLVED → VERIFIED
Target Milestone: --- → Builder 0.9.6
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.